Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: webkit/fileapi/file_system_url_request_job.cc

Issue 8231004: Remaining cleanup (base::Bind): Replacing FileUtilProxy calls with new callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/file_system_url_request_job.cc
diff --git a/webkit/fileapi/file_system_url_request_job.cc b/webkit/fileapi/file_system_url_request_job.cc
index 8c28ded57f620be4f162c31c476e2b2e955ec09f..18762804fa1e022bf57ffaa8fdbfc7b0066c598e 100644
--- a/webkit/fileapi/file_system_url_request_job.cc
+++ b/webkit/fileapi/file_system_url_request_job.cc
@@ -106,7 +106,6 @@ FileSystemURLRequestJob::FileSystemURLRequestJob(
: URLRequestJob(request),
file_system_context_(file_system_context),
file_thread_proxy_(file_thread_proxy),
- ALLOW_THIS_IN_INITIALIZER_LIST(method_factory_(this)),
ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)),
stream_(NULL),
is_directory_(false),
@@ -121,9 +120,10 @@ FileSystemURLRequestJob::~FileSystemURLRequestJob() {
}
void FileSystemURLRequestJob::Start() {
- MessageLoop::current()->PostTask(FROM_HERE,
- method_factory_.NewRunnableMethod(
- &FileSystemURLRequestJob::StartAsync));
+ MessageLoop::current()->PostTask(
+ FROM_HERE,
+ base::Bind(&FileSystemURLRequestJob::StartAsync,
+ weak_factory_.GetWeakPtr()));
}
void FileSystemURLRequestJob::Kill() {
@@ -132,7 +132,6 @@ void FileSystemURLRequestJob::Kill() {
stream_.reset(NULL);
}
URLRequestJob::Kill();
- method_factory_.RevokeAll();
weak_factory_.InvalidateWeakPtrs();
}

Powered by Google App Engine
This is Rietveld 408576698