Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Unified Diff: webkit/blob/blob_url_request_job.cc

Issue 8231004: Remaining cleanup (base::Bind): Replacing FileUtilProxy calls with new callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/blob/blob_url_request_job.cc
diff --git a/webkit/blob/blob_url_request_job.cc b/webkit/blob/blob_url_request_job.cc
index 09491e897073c12c3c1223d0fc6abb11e472ea35..fe2321e68fdd75ad1ad29ece1c05ff8ca6e61c40 100644
--- a/webkit/blob/blob_url_request_job.cc
+++ b/webkit/blob/blob_url_request_job.cc
@@ -65,8 +65,7 @@ BlobURLRequestJob::BlobURLRequestJob(
bytes_to_read_(0),
error_(false),
headers_set_(false),
- byte_range_set_(false),
- ALLOW_THIS_IN_INITIALIZER_LIST(method_factory_(this)) {
+ byte_range_set_(false) {
DCHECK(file_thread_proxy_);
}
@@ -80,7 +79,8 @@ void BlobURLRequestJob::Start() {
// Continue asynchronously.
MessageLoop::current()->PostTask(
FROM_HERE,
- method_factory_.NewRunnableMethod(&BlobURLRequestJob::DidStart));
+ base::Bind(&BlobURLRequestJob::DidStart,
+ weak_factory_.GetWeakPtr()));
}
void BlobURLRequestJob::DidStart() {
@@ -111,7 +111,6 @@ void BlobURLRequestJob::Kill() {
net::URLRequestJob::Kill();
weak_factory_.InvalidateWeakPtrs();
- method_factory_.RevokeAll();
}
void BlobURLRequestJob::ResolveFile(const FilePath& file_path) {

Powered by Google App Engine
This is Rietveld 408576698