Send PING to check the status of the SPDY connection.

net/http/http_network_layer.cc

Index: net/http/http_network_layer.cc
===================================================================
--- net/http/http_network_layer.cc	(revision 105385)
+++ net/http/http_network_layer.cc	(working copy)
@@ -42,6 +42,7 @@
   static const char kOff[] = "off";
   static const char kSSL[] = "ssl";
   static const char kDisableSSL[] = "no-ssl";
+  static const char kDisablePing[] = "no-ping";

[willchan no longer on Chromium, 2011/10/15 08:08:03]

Not that I really care, but why are we adding a flag to disable this? Is there a
good reason for users/devs to want to do this?

[jar (doing other things), 2011/10/15 09:00:52]

The concern was that this was being added late in the feature cycle.  IF it is
seen to be broken, we can disable it via the flag.  The flag will probably go
away after we have more field experience.

Putting new features "under control of a flag" was requested as best-practice
for larger features, but seems to make sense with smaller features landing this
late.  

We also needed the infrastructure to make testing easier... so it was almost a
freebie.

On 2011/10/15 08:08:03, willchan wrote:

[willchan no longer on Chromium, 2011/10/15 20:17:40]

OK, that sounds reasonable. Although I really really don't want to turn this
off. It'd be great if instead we could just fall back easily to a dumber / less
optimized code path, because this is a pretty important bugfix.

On 2011/10/15 09:00:52, jar wrote:

   static const char kExclude[] = "exclude";  // Hosts to exclude
   static const char kDisableCompression[] = "no-compress";
   static const char kDisableAltProtocols[] = "no-alt-protocols";
@@ -101,6 +102,8 @@
     } else if (option == kSSL) {
       HttpStreamFactory::set_force_spdy_over_ssl(true);
       HttpStreamFactory::set_force_spdy_always(true);
+    } else if (option == kDisablePing) {
+      SpdySession::set_enable_ping_based_connection_checking(false);
     } else if (option == kExclude) {
       HttpStreamFactory::add_forced_spdy_exclusion(value);
     } else if (option == kDisableCompression) {