Send PING to check the status of the SPDY connection.

net/http/http_stream_factory_impl_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_factory_impl.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "net/base/cert_verifier.h"
@@ skipping 326 matching lines @@
     peer.SetSocketPoolForSSLWithProxy(proxy_host, ssl_conn_pool);
     PreconnectHelper(kTests[i], session);
     if (kTests[i].ssl)
       EXPECT_EQ(kTests[i].num_streams, ssl_conn_pool->last_num_streams());
     else
       EXPECT_EQ(kTests[i].num_streams, socks_proxy_pool->last_num_streams());
   }
 }
 
 TEST(HttpStreamFactoryTest, PreconnectDirectWithExistingSpdySession) {
+  // Disable sending PING.
+  SpdySession::set_enable_ping_based_connection_checking(false);

[willchan no longer on Chromium, 2011/10/15 08:08:03]

It looks weird that we are only disabling PING for this single test. I think we
probably want to disable it for all tests by default. I think you should take
out all of these calls and move them into net/base/run_all_unittests.cc, and
then only enable it for the unit tests that specifically test PING.

[ramant (doing other things), 2011/10/15 23:33:11]

Done.

   for (size_t i = 0; i < arraysize(kTests); ++i) {
     SessionDependencies session_deps(ProxyService::CreateDirect());
     scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps));
     HttpNetworkSessionPeer peer(session);
 
     // Set an existing SpdySession in the pool.
     HostPortPair host_port_pair("www.google.com", 443);
     HostPortProxyPair pair(host_port_pair, ProxyServer::Direct());
     scoped_refptr<SpdySession> spdy_session =
         session->spdy_session_pool()->Get(pair, BoundNetLog());
@@ skipping 57 matching lines @@
   const ProxyRetryInfoMap& retry_info =
       session->proxy_service()->proxy_retry_info();
   EXPECT_EQ(1u, retry_info.size());
   ProxyRetryInfoMap::const_iterator iter = retry_info.find("bad:99");
   EXPECT_TRUE(iter != retry_info.end());
 }
 
 }  // namespace
 
 }  // namespace net