Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 8230012: Cleanup AppCacheQuotaClient using new Callback (Closed)

Created:
9 years, 2 months ago by tzik
Modified:
9 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Cleanup AppCacheQuotaClient using new Callback BUG=None TEST=AppCacheQuotaClientTest.PendingRequests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106233

Patch Set 1 #

Patch Set 2 : fix infinite recursion #

Total comments: 2

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -107 lines) Patch
M webkit/appcache/appcache_quota_client.h View 1 4 chunks +4 lines, -32 lines 0 comments Download
M webkit/appcache/appcache_quota_client.cc View 1 10 chunks +32 lines, -71 lines 0 comments Download
M webkit/appcache/appcache_storage_impl.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tzik
Hi. This is another pass of Quota related callback refactoring. (http://codereview.chromium.org/8070001/ .) In this CL, ...
9 years, 2 months ago (2011-10-11 13:13:13 UTC) #1
michaeln
this lgtm, although can you explain why the first snapshot didn't work, how it introduced ...
9 years, 2 months ago (2011-10-11 19:18:40 UTC) #2
tzik
Sure. http://codereview.chromium.org/8230012/diff/5/webkit/appcache/appcache_quota_client.cc File webkit/appcache/appcache_quota_client.cc (left): http://codereview.chromium.org/8230012/diff/5/webkit/appcache/appcache_quota_client.cc#oldcode162 webkit/appcache/appcache_quota_client.cc:162: service_delete_callback_); In current implementation, we call service->DeleteAppCachesForOrigin() directly. ...
9 years, 2 months ago (2011-10-12 01:58:23 UTC) #3
michaeln
http://codereview.chromium.org/8230012/diff/5/webkit/appcache/appcache_quota_client.cc File webkit/appcache/appcache_quota_client.cc (left): http://codereview.chromium.org/8230012/diff/5/webkit/appcache/appcache_quota_client.cc#oldcode162 webkit/appcache/appcache_quota_client.cc:162: service_delete_callback_); On 2011/10/12 01:58:23, tzik wrote: > In current ...
9 years, 2 months ago (2011-10-12 06:36:54 UTC) #4
awong
LGTM for the callback usage. As for the logic change on quota delete, I think ...
9 years, 2 months ago (2011-10-12 07:28:06 UTC) #5
tzik
Thanks a lot. If no problem, I'll put it in CQ after 8070001 lands.
9 years, 2 months ago (2011-10-12 14:59:41 UTC) #6
michaeln
yup... lgtm... thnx!
9 years, 2 months ago (2011-10-12 18:46:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/8230012/12001
9 years, 2 months ago (2011-10-19 03:35:18 UTC) #8
commit-bot: I haz the power
9 years, 2 months ago (2011-10-19 05:40:46 UTC) #9
Change committed as 106233

Powered by Google App Engine
This is Rietveld 408576698