Issue 8230009: Adjust assertions in the incremental marking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8230009: Adjust assertions in the incremental marking. (Closed)

Created:
9 years, 2 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Adjust assertions in the incremental marking. Now we are completely transfering marks when shifting arrays in-place. This might lead to white free space objects in the marking deque. R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=9580

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use IsFiller instead of IsFreeSpace to cover two pointer fillers #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	src/incremental-marking.cc	View	1	4 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

http://codereview.chromium.org/8230009/diff/1/src/incremental-marking.cc File src/incremental-marking.cc (right): http://codereview.chromium.org/8230009/diff/1/src/incremental-marking.cc#newcode523 src/incremental-marking.cc:523: (obj->IsFreeSpace() && Marking::IsWhite(mark_bit))); Does IsFreeSpace() cover two-pointer-filler maps? I ...

9 years, 2 months ago (2011-10-11 11:31:46 UTC) #2

The second patch set LGTM.

Expand Messages | Collapse Messages