Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 8230006: Use the OpenBSD header for ICU on OpenBSD (Closed)

Created:
9 years, 2 months ago by Robert Nagy
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/deps/icu46.git@master
Visibility:
Public.

Description

Use the OpenBSD header for ICU on OpenBSD add ICU header for OpenBSD Patch by Robert Nagy <robert.nagy@gmail.com>; BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106495

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add OpenBSD bits to README.chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -2 lines) Patch
M README.chromium View 1 2 chunks +7 lines, -2 lines 0 comments Download
A public/common/unicode/popenbsd.h View 1 chunk +313 lines, -0 lines 0 comments Download
M public/common/unicode/ptypes.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Robert Nagy
9 years, 2 months ago (2011-10-11 11:04:55 UTC) #1
Hironori Bono
Greetings, I have added Jungshik, who is the owner of ICU files. Regards, Hironori Bono
9 years, 2 months ago (2011-10-12 08:51:32 UTC) #2
Robert Nagy
9 years, 2 months ago (2011-10-12 09:05:41 UTC) #3
Robert Nagy
9 years, 2 months ago (2011-10-13 07:50:46 UTC) #4
Mark Mentovai
http://codereview.chromium.org/8230006/diff/1/public/common/unicode/popenbsd.h File public/common/unicode/popenbsd.h (right): http://codereview.chromium.org/8230006/diff/1/public/common/unicode/popenbsd.h#newcode1 public/common/unicode/popenbsd.h:1: /* You should say something about this file in ...
9 years, 2 months ago (2011-10-13 15:01:11 UTC) #5
Robert Nagy
http://codereview.chromium.org/8230006/diff/1/public/common/unicode/popenbsd.h File public/common/unicode/popenbsd.h (right): http://codereview.chromium.org/8230006/diff/1/public/common/unicode/popenbsd.h#newcode1 public/common/unicode/popenbsd.h:1: /* On 2011/10/13 15:01:11, Mark Mentovai wrote: > You ...
9 years, 2 months ago (2011-10-13 15:47:23 UTC) #6
Mark Mentovai
Great, that answers my question. LGTM.
9 years, 2 months ago (2011-10-13 16:32:42 UTC) #7
Robert Nagy
On 2011/10/13 16:32:42, Mark Mentovai wrote: > Great, that answers my question. LGTM. Can we ...
9 years, 2 months ago (2011-10-20 13:31:20 UTC) #8
Mark Mentovai
I gave LGTM and checked the commit box, and I guess nothing happened after that. ...
9 years, 2 months ago (2011-10-20 13:46:56 UTC) #9
Robert Nagy
On 2011/10/20 13:46:56, Mark Mentovai wrote: > I gave LGTM and checked the commit box, ...
9 years, 2 months ago (2011-10-20 14:39:24 UTC) #10
Mark Mentovai
I committed r106495 manually and will roll DEPS to pick this up in Chromium shortly.
9 years, 2 months ago (2011-10-20 14:46:15 UTC) #11
Robert Nagy
On 2011/10/20 14:46:15, Mark Mentovai wrote: > I committed r106495 manually and will roll DEPS ...
9 years, 2 months ago (2011-10-20 14:46:34 UTC) #12
Mark Mentovai
9 years, 2 months ago (2011-10-20 14:51:48 UTC) #13
Incorporated into Chrome’s DEPS at r106496.

Powered by Google App Engine
This is Rietveld 408576698