Issue 8229008: Fix handling of this in direct calls to function proxies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8229008: Fix handling of this in direct calls to function proxies. (Closed)

Created:
9 years, 2 months ago by rossberg

Modified:
9 years, 2 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix handling of this in direct calls to function proxies. Fix & tweak some proxy-related error messages. R=kmillikin@chromium.org BUG=v8:1543 TEST= Committed: http://code.google.com/p/v8/source/detail?r=9613

Patch Set 1 #

Patch Set 2 : Activated previously broken tests. #

Patch Set 3 : Test for one more code path. #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -26 lines)			Patch
M	src/ic.cc	View		2 chunks	+4 lines, -1 line	1 comment	Download
M	src/messages.js	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/objects.cc	View		4 chunks	+8 lines, -2 lines	0 comments	Download
M	test/mjsunit/harmony/proxies-function.js	View	1 2	3 chunks	+57 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 2 months ago (2011-10-13 14:36:40 UTC) #2

lgtm

http://codereview.chromium.org/8229008/diff/4005/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/8229008/diff/4005/src/ic.cc#newcode434
src/ic.cc:434: callee =
Handle<Object>(JSFunctionProxy::cast(*callee)->call_trap());
V8 style is braces around this body (unless it could fit on the previous line).

Expand Messages | Collapse Messages