Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 8228010: Fix free list node ending up on evacuation candidate. (Closed)

Created:
9 years, 2 months ago by Michael Starzinger
Modified:
9 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix free list node ending up on evacuation candidate. This is a temporary fix which avoids compaction when incremental marking is restarted during an old-space-step. That could turn the page that holds the chosen free list node into an evacuation candidate. It could also cause several other inconsistencies if it happens during scavenge. R=vegorov@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=9585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M src/incremental-marking.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/incremental-marking.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/spaces.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
lgtm
9 years, 2 months ago (2011-10-11 16:45:59 UTC) #1
Michael Starzinger
9 years, 2 months ago (2011-10-11 16:47:13 UTC) #2
Brand new CL, this time against bleeding edge.

Powered by Google App Engine
This is Rietveld 408576698