Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7187)

Unified Diff: chrome/browser/ui/webui/bidi_checker_web_ui_test.h

Issue 8228009: Adding more bidichecker tests and doing some minor cleanups. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: A bunch of cleanups as discussed with Jeremy Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/bidi_checker_web_ui_test.h
diff --git a/chrome/browser/ui/webui/bidi_checker_web_ui_test.h b/chrome/browser/ui/webui/bidi_checker_web_ui_test.h
index 42992fe22c21a8dcc5edc7ae859309a402b285e9..d9c10ad879e3720f7c923a637e193ba633bf1402 100644
--- a/chrome/browser/ui/webui/bidi_checker_web_ui_test.h
+++ b/chrome/browser/ui/webui/bidi_checker_web_ui_test.h
@@ -15,27 +15,31 @@ class WebUIBidiCheckerBrowserTest : public WebUIBrowserTest {
public:
virtual ~WebUIBidiCheckerBrowserTest();
+ protected:
+ WebUIBidiCheckerBrowserTest();
+
// Runs the Bidi Checker on the given page URL. |isRTL| should be true when
// the active page locale is RTL.
void RunBidiCheckerOnPage(const char pageURL[], bool isRTL);
- protected:
- WebUIBidiCheckerBrowserTest();
-
// Setup test path.
virtual void SetUpInProcessBrowserTestFixture() OVERRIDE;
};
+// Base class for BidiChecker-based tests that run with an LTR UI.
+class WebUIBidiCheckerBrowserTestLTR : public WebUIBidiCheckerBrowserTest {
+public:
+ virtual void RunBidiCheckerOnPage(const char pageURL[]);
jeremy 2011/10/25 09:19:53 Why is this virtual?
ofri1 2011/10/30 09:42:40 Leftover. Fixed.
+};
+
// Base class for BidiChecker-based tests that run with an RTL UI.
// Preloads the BidiChecker JS library for each test, as well as modifies the
// active language.
-class WebUIBidiCheckerBrowserTestFakeBidi : public WebUIBidiCheckerBrowserTest {
+class WebUIBidiCheckerBrowserTestRTL : public WebUIBidiCheckerBrowserTest {
public:
- virtual ~WebUIBidiCheckerBrowserTestFakeBidi();
+ virtual void RunBidiCheckerOnPage(const char pageURL[]);
protected:
- WebUIBidiCheckerBrowserTestFakeBidi();
-
virtual void SetUpOnMainThread() OVERRIDE;
virtual void CleanUpOnMainThread() OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698