Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2946)

Unified Diff: chrome/test/data/webui/bidichecker_tests.js

Issue 8228009: Adding more bidichecker tests and doing some minor cleanups. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: More comments fixes Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/bidichecker_tests.js
diff --git a/chrome/test/data/webui/bidichecker_tests.js b/chrome/test/data/webui/bidichecker_tests.js
index b78d87f46aa6a4c1c0bb21bdada2b17bd36eb56f..ec7c055c3ad45c7bd8412280bd042caedb846d99 100644
--- a/chrome/test/data/webui/bidichecker_tests.js
+++ b/chrome/test/data/webui/bidichecker_tests.js
@@ -20,12 +20,12 @@ function filtersForPage(pageName, isRTL) {
"chrome://history" : {
// Filters for LTR UI
"LTR" : [
- // BUG: http://code.google.com/p/chromium/issues/detail?id=80791
+ // BUG: http://crbug.com/80791
bidichecker.FilterFactory.atText("בדיקה")
],
// Filters for RTL UI
"RTL" : [
- // BUG: http://code.google.com/p/chromium/issues/detail?id=80791
+ // BUG: http://crbug.com/80791
bidichecker.FilterFactory.atText("Google"),
// The following two are probably false positives since we can't
// completely change the environment to RTL on Linux.
@@ -36,11 +36,11 @@ function filtersForPage(pageName, isRTL) {
},
"chrome://settings/autofill" : {
"LTR" : [
- // BUG: http://code.google.com/p/chromium/issues/detail?id=82267
+ // BUG: http://crbug.com/82267
bidichecker.FilterFactory.atText("משה ב כהן, דרך מנחם בגין")
],
"RTL" : [
- // BUG: http://code.google.com/p/chromium/issues/detail?id=90322
+ // BUG: http://crbug.com/90322
bidichecker.FilterFactory.atText(
"Milton C. Waddams, 4120 Freidrich Lane")
]
@@ -56,10 +56,55 @@ function filtersForPage(pageName, isRTL) {
},
"chrome://newtab" : {
"RTL" : [
- // BUG: http://code.google.com/p/chromium/issues/detail?id=93339
+ // BUG: http://crbug.com/93339
bidichecker.FilterFactory.atText("Chrome Web Store"),
bidichecker.FilterFactory.atText("File Manager")
]
+ },
+ "chrome://bugreport#0?description=%D7%91%D7%93%D7%99%D7%A7%D7%94&issueType=1" : {
+ "LTR" : [
+ // BUG: http://crbug.com/90835
+ bidichecker.FilterFactory.atText("בדיקה")
+ ]
+ },
+ "chrome://bugreport#0?description=test&issueType=1" : {
+ "RTL" : [
+ // BUG: http://crbug.com/90835
+ bidichecker.FilterFactory.atText("test")
+ ]
+ },
+ "chrome://settings/browser" : {
+ "LTR" : [
+ // BUG: http://crbug.com/93702
+ bidichecker.FilterFactory.atText("חדשות תוכן ועדכונים - ידיעות אחרונות")
+ ]
+ },
+ "chrome://settings/clearBrowserData" : {
+ "RTL" : [
+ // BUG: http://crbug.com/94070
+ bidichecker.FilterFactory.atText("Google Cloud Print")
+ ]
+ },
+ "chrome://settings/content" : {
+ "RTL" : [
+ // BUG: http://crbug.com/94070
+ bidichecker.FilterFactory.atText("Google Cloud Print")
+ ]
+ },
+ "chrome://settings/languages" : {
+ "RTL" : [
+ // BUG: http://crbug.com/94070
+ bidichecker.FilterFactory.atText("Google Cloud Print"),
+ bidichecker.FilterFactory.atText("Hebrew"),
+ bidichecker.FilterFactory.atText("English (United States"),
+ bidichecker.FilterFactory.atText("English")
+ ]
+ },
+ "chrome://settings/contentExceptions" : {
+ "RTL" : [
+ // BUG: http://crbug.com/94070
+ bidichecker.FilterFactory.atText("Google Cloud Print")
+ ]
}
};

Powered by Google App Engine
This is Rietveld 408576698