Chromium Code Reviews| Index: chrome/browser/ui/webui/bidi_checker_web_ui_test.h |
| diff --git a/chrome/browser/ui/webui/bidi_checker_web_ui_test.h b/chrome/browser/ui/webui/bidi_checker_web_ui_test.h |
| index 42992fe22c21a8dcc5edc7ae859309a402b285e9..1fd62e67864769d22e61802af4b7d8e0e4af75cc 100644 |
| --- a/chrome/browser/ui/webui/bidi_checker_web_ui_test.h |
| +++ b/chrome/browser/ui/webui/bidi_checker_web_ui_test.h |
| @@ -15,27 +15,31 @@ class WebUIBidiCheckerBrowserTest : public WebUIBrowserTest { |
| public: |
| virtual ~WebUIBidiCheckerBrowserTest(); |
| + protected: |
| + WebUIBidiCheckerBrowserTest(); |
| + |
| // Runs the Bidi Checker on the given page URL. |isRTL| should be true when |
| // the active page locale is RTL. |
| void RunBidiCheckerOnPage(const char pageURL[], bool isRTL); |
| - protected: |
| - WebUIBidiCheckerBrowserTest(); |
| - |
| // Setup test path. |
| virtual void SetUpInProcessBrowserTestFixture() OVERRIDE; |
| }; |
| +// Base class for BidiChecker-based tests that run with an LTR UI. |
| +class WebUIBidiCheckerBrowserTestLTR : public WebUIBidiCheckerBrowserTest { |
| +public: |
|
jeremy
2011/10/30 09:59:19
one space before public.
ofri1
2011/10/30 12:52:14
Done.
|
| + void RunBidiCheckerOnPage(const char pageURL[]); |
| +}; |
| + |
| // Base class for BidiChecker-based tests that run with an RTL UI. |
| // Preloads the BidiChecker JS library for each test, as well as modifies the |
| // active language. |
|
jeremy
2011/10/30 09:59:19
I think you can remove lines 2-3 of this comment.
ofri1
2011/10/30 12:52:14
Done.
|
| -class WebUIBidiCheckerBrowserTestFakeBidi : public WebUIBidiCheckerBrowserTest { |
| +class WebUIBidiCheckerBrowserTestRTL : public WebUIBidiCheckerBrowserTest { |
| public: |
| - virtual ~WebUIBidiCheckerBrowserTestFakeBidi(); |
| + void RunBidiCheckerOnPage(const char pageURL[]); |
| protected: |
| - WebUIBidiCheckerBrowserTestFakeBidi(); |
| - |
| virtual void SetUpOnMainThread() OVERRIDE; |
| virtual void CleanUpOnMainThread() OVERRIDE; |