Adding more bidichecker tests and doing some minor cleanups.

chrome/browser/ui/webui/bidi_checker_web_ui_test.h

Index: chrome/browser/ui/webui/bidi_checker_web_ui_test.h
diff --git a/chrome/browser/ui/webui/bidi_checker_web_ui_test.h b/chrome/browser/ui/webui/bidi_checker_web_ui_test.h
index 42992fe22c21a8dcc5edc7ae859309a402b285e9..ebee20965df96f9b1685e5175982eed798be082c 100644
--- a/chrome/browser/ui/webui/bidi_checker_web_ui_test.h
+++ b/chrome/browser/ui/webui/bidi_checker_web_ui_test.h
@@ -18,6 +18,8 @@ class WebUIBidiCheckerBrowserTest : public WebUIBrowserTest {
   // Runs the Bidi Checker on the given page URL. |isRTL| should be true when
   // the active page locale is RTL.
   void RunBidiCheckerOnPage(const char pageURL[], bool isRTL);
+  // Same as above but automatically sets the |isRTL| flag.
+  virtual void RunBidiCheckerOnPage(const char pageURL[]);

[jeremy, 2011/10/16 12:54:59]

I would just define 2 functions and make the above function private.

Named something like:
virtual void RunBidiCheckerOnPageAsLTR();
virtual void RunBidiCheckerOnPageAsRTL();

 
  protected:
   WebUIBidiCheckerBrowserTest();
@@ -32,6 +34,7 @@ class WebUIBidiCheckerBrowserTest : public WebUIBrowserTest {
 class WebUIBidiCheckerBrowserTestFakeBidi : public WebUIBidiCheckerBrowserTest {
  public:
   virtual ~WebUIBidiCheckerBrowserTestFakeBidi();
+  virtual void RunBidiCheckerOnPage(const char pageURL[]);

[jeremy, 2011/10/16 12:54:59]

specify OVERRIDE in the function definition.

 
  protected:
   WebUIBidiCheckerBrowserTestFakeBidi();