openbsd and freebsd fixes for base

build/common.gypi

Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index dbdd9cb29e5ea955a5bb5cbd5fd0de34d272772f..bcff02f7bd724d7b2f2f3e13eb7bcb79a1a0313f 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1106,7 +1106,7 @@
     'target_conditions': [
       ['chromium_code==0', {
         'conditions': [
-          [ 'os_posix==1 and OS!="mac"', {
+          [ 'os_posix==1 and OS!="mac" and OS!="openbsd"', {

[Mark Mentovai, 2011/10/12 14:58:02]

Why?

[Robert Nagy, 2011/10/12 17:03:10]

The comment states exactly: We don't want to get warning from third-party code,
not to mention that on at least OpenBSD the gcc version is 4.2 which means that
some of the flags are going to be unsupported. And since everything else  above
4.2 is GPLv3, there is no chance we are getting a newer compiler in the near
future.

[Mark Mentovai, 2011/10/12 18:42:56]

Robert Nagy wrote:
Right…

This block is responsible for removing -Wall, -Werror, and -Wextra. You’re
removing this block from OS=="openbsd", so that -Wall -Werror, and -Wextra will
NOT be removed on OpenBSD—in other words, third_party code will still build with
-Wall, -Werror, and -Wextra on OpenBSD. I didn’t think that’s what you want, and
your response to my question seems to confirm that.

See below for an explanation of why I suspect this confused you.

[Robert Nagy, 2011/10/12 19:33:39]

Oh yeah, you are right, removing that.

On 2011/10/12 18:42:56, Mark Mentovai wrote:

             # We don't want to get warnings from third-party code,
             # so remove any existing warning-enabling flags like -Wall.
             'cflags!': [
@@ -1127,7 +1127,7 @@
               '-Wsign-compare',
             ]
           }],
-          [ 'os_posix==1 and OS!="mac" and chromeos==0', {
+          [ 'os_posix==1 and OS!="mac" and OS!="openbsd" and chromeos==0', {

[Mark Mentovai, 2011/10/12 14:58:02]

Why?

[Robert Nagy, 2011/10/12 17:03:10]

-Wno-unused-result is unsupported

[Mark Mentovai, 2011/10/12 18:42:56]

Robert Nagy wrote:
You should add something about OpenBSD needing to use GCC 4.2 in the comment
below, then.

[Robert Nagy, 2011/10/12 19:33:39]

Done.

             'cflags': [
               # Don't warn about ignoring the return value from e.g. close().
               # This is off by default in some gccs but on by default in others.