openbsd and freebsd fixes for base

build/common.gypi

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 1088 matching lines @@
       }],
       ['enable_web_intents==1', {
         'defines': [
           'ENABLE_WEB_INTENTS=1',
         ],
       }],
     ],  # conditions for 'target_defaults'
     'target_conditions': [
       ['chromium_code==0', {
         'conditions': [
-          [ 'os_posix==1 and OS!="mac"', {
+          [ 'os_posix==1 and OS!="mac" and OS!="openbsd"', {

[Mark Mentovai, 2011/10/12 14:58:02]

Why?

[Robert Nagy, 2011/10/12 17:03:10]

The comment states exactly: We don't want to get warning from third-party code,
not to mention that on at least OpenBSD the gcc version is 4.2 which means that
some of the flags are going to be unsupported. And since everything else  above
4.2 is GPLv3, there is no chance we are getting a newer compiler in the near
future.

[Mark Mentovai, 2011/10/12 18:42:56]

Robert Nagy wrote:
Right…

This block is responsible for removing -Wall, -Werror, and -Wextra. You’re
removing this block from OS=="openbsd", so that -Wall -Werror, and -Wextra will
NOT be removed on OpenBSD—in other words, third_party code will still build with
-Wall, -Werror, and -Wextra on OpenBSD. I didn’t think that’s what you want, and
your response to my question seems to confirm that.

See below for an explanation of why I suspect this confused you.

[Robert Nagy, 2011/10/12 19:33:39]

Oh yeah, you are right, removing that.

On 2011/10/12 18:42:56, Mark Mentovai wrote:

             # We don't want to get warnings from third-party code,
             # so remove any existing warning-enabling flags like -Wall.
             'cflags!': [
               '-Wall',
               '-Wextra',
               '-Werror',
             ],
             'cflags': [
               # Don't warn about hash_map in third-party code.
               '-Wno-deprecated',
               # Don't warn about printf format problems.
               # This is off by default in gcc but on in Ubuntu's gcc(!).
               '-Wno-format',
             ],
             'cflags_cc!': [
               # TODO(fischman): remove this.
               # http://code.google.com/p/chromium/issues/detail?id=90453
               '-Wsign-compare',
             ]
           }],
-          [ 'os_posix==1 and OS!="mac" and chromeos==0', {
+          [ 'os_posix==1 and OS!="mac" and OS!="openbsd" and chromeos==0', {

[Mark Mentovai, 2011/10/12 14:58:02]

Why?

[Robert Nagy, 2011/10/12 17:03:10]

-Wno-unused-result is unsupported

[Mark Mentovai, 2011/10/12 18:42:56]

Robert Nagy wrote:
You should add something about OpenBSD needing to use GCC 4.2 in the comment
below, then.

[Robert Nagy, 2011/10/12 19:33:39]

Done.

             'cflags': [
               # Don't warn about ignoring the return value from e.g. close().
               # This is off by default in some gccs but on by default in others.
               # Currently this option is not set for Chrome OS build because
               # the current version of gcc (4.3.4) used for building Chrome in
               # Chrome OS chroot doesn't support this option.
               # TODO(mazda): remove the conditional for Chrome OS when gcc
               # version is upgraded.
               '-Wno-unused-result',
             ],
@@ skipping 15 matching lines @@
             },
           }],
           # TODO(darin): Unfortunately, some third_party code depends on base/
           [ 'OS=="win" and component=="shared_library"', {
             'msvs_disabled_warnings': [
               4251,  # class 'std::xx' needs to have dll-interface.
             ],
           }],
           [ 'OS=="mac"', {
             'xcode_settings': {
               'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO',

[Mark Mentovai, 2011/10/12 18:42:56]

The reason that you saw OS="mac" above is that we don’t control warnings with
the 'cflags' GYP property, we do it this way inside 'xcode_settings'.

               'WARNING_CFLAGS!': ['-Wall', '-Wextra'],
             },
           }],
         ],
       }, {
         # In Chromium code, we define __STDC_FORMAT_MACROS in order to get the
         # C99 macros on Mac and Linux.
         'defines': [
           '__STDC_FORMAT_MACROS',
         ],
@@ skipping 1343 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }