Sync Promo: Close browser tab when closing promo

Sync Promo: Close browser tab when closing promo

This is part one of a two part change to adjust how we show the sync promo at startup.

Currently, at startup, we show the sync promo and the welcome page. When the user completes the promo (or skips it) we navigate to the new tab page.

We want to adjust the start up flow so that instead of replacing the standard first tab with the sync promo we show it along side the promo.

For example, if the standard startup tabs would be:
  Google.com, Welcome
Then the new startup tabs will be:
  Sync Promo, Google.com, Welcome

Once the user completes (or skips) the sync promo we want to leave them with the same set of tabs that they would normally have. To do this we want to close the sync promo tab.

This CL is simply the first part of that work. If the promo page was displayed at startup then we close the browser tab once the user completes the sync setup. To detect that the promo was displayed at startup we just check the back history for the tab. There's no back history only when the promo page was displayed at startup.

BUG=99743
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105174

[sail, 2011-10-12 06:27:33]

jhawkins: please review
sky: FYI

[James Hawkins, 2011-10-12 17:34:18]

http://codereview.chromium.org/8227038/diff/3001/chrome/browser/ui/browser_li...
File chrome/browser/ui/browser_list.cc (right):

http://codereview.chromium.org/8227038/diff/3001/chrome/browser/ui/browser_li...
chrome/browser/ui/browser_list.cc:687: Browser*
BrowserList::FindBrowserWithTabContents(TabContents* tab_contents) {
DCHECK(tab_contents).

http://codereview.chromium.org/8227038/diff/3001/chrome/browser/ui/browser_li...
chrome/browser/ui/browser_list.cc:689: TabContents* tab = it->tab_contents();
if (it->tab_contents() == tab_contents)
  return it.browser().

http://codereview.chromium.org/8227038/diff/3001/chrome/browser/ui/browser_li...
File chrome/browser/ui/browser_list.h (right):

http://codereview.chromium.org/8227038/diff/3001/chrome/browser/ui/browser_li...
chrome/browser/ui/browser_list.h:104: static Browser*
FindBrowserWithTabContents(TabContents* tab_contents);
|tab_contents| must not be NULL.

http://codereview.chromium.org/8227038/diff/3001/chrome/browser/ui/webui/sync...
File chrome/browser/ui/webui/sync_promo_handler.cc (right):

http://codereview.chromium.org/8227038/diff/3001/chrome/browser/ui/webui/sync...
chrome/browser/ui/webui/sync_promo_handler.cc:128: // If there's no previous
page on this tab then it means that the promo was
Is this the best signal we have that the promo was displayed at startup?  It
seems kinda hacky.

[sail, 2011-10-12 17:54:12]

http://codereview.chromium.org/8227038/diff/3001/chrome/browser/ui/browser_li...
File chrome/browser/ui/browser_list.cc (right):

http://codereview.chromium.org/8227038/diff/3001/chrome/browser/ui/browser_li...
chrome/browser/ui/browser_list.cc:687: Browser*
BrowserList::FindBrowserWithTabContents(TabContents* tab_contents) {
On 2011/10/12 17:34:18, James Hawkins wrote:
> DCHECK(tab_contents).

Done.

http://codereview.chromium.org/8227038/diff/3001/chrome/browser/ui/browser_li...
chrome/browser/ui/browser_list.cc:689: TabContents* tab = it->tab_contents();
On 2011/10/12 17:34:18, James Hawkins wrote:
> if (it->tab_contents() == tab_contents)
>   return it.browser().

Done.

http://codereview.chromium.org/8227038/diff/3001/chrome/browser/ui/browser_li...
chrome/browser/ui/browser_list.cc:689: TabContents* tab = it->tab_contents();
On 2011/10/12 17:34:18, James Hawkins wrote:
> if (it->tab_contents() == tab_contents)
>   return it.browser().

Done.

http://codereview.chromium.org/8227038/diff/3001/chrome/browser/ui/browser_li...
File chrome/browser/ui/browser_list.h (right):

http://codereview.chromium.org/8227038/diff/3001/chrome/browser/ui/browser_li...
chrome/browser/ui/browser_list.h:104: static Browser*
FindBrowserWithTabContents(TabContents* tab_contents);
On 2011/10/12 17:34:18, James Hawkins wrote:
> |tab_contents| must not be NULL.

Done.

http://codereview.chromium.org/8227038/diff/3001/chrome/browser/ui/webui/sync...
File chrome/browser/ui/webui/sync_promo_handler.cc (right):

http://codereview.chromium.org/8227038/diff/3001/chrome/browser/ui/webui/sync...
chrome/browser/ui/webui/sync_promo_handler.cc:128: // If there's no previous
page on this tab then it means that the promo was
On 2011/10/12 17:34:18, James Hawkins wrote:
> Is this the best signal we have that the promo was displayed at startup?  It
> seems kinda hacky.

An alternative would be to add some kind of parameter to the URL but I think
this approach is much cleaner.

[James Hawkins, 2011-10-12 17:57:59]

lgtm

[commit-bot: I haz the power, 2011-10-12 18:00:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8227038/8001

[commit-bot: I haz the power, 2011-10-12 18:00:06]

Can't apply patch for file chrome/browser/ui/webui/sync_promo_handler.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/ui/webui/sync_promo_handler.cc
Hunk #1 FAILED at 13.
Hunk #2 succeeded at 23 (offset 1 line).
Hunk #3 succeeded at 124 (offset 1 line).
1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/ui/webui/sync_promo_handler.cc.rej

[commit-bot: I haz the power, 2011-10-12 18:06:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8227038/9007

[commit-bot: I haz the power, 2011-10-12 22:28:31]

Change committed as 105174