chrome/renderer/print_web_view_helper_browsertest.cc - Issue 8227034: Change print setting conventions for margins to support more options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/print_web_view_helper_browsertest.cc

Issue 8227034: Change print setting conventions for margins to support more options. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix test compile Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/print_web_view_helper_browsertest.cc

diff --git a/chrome/renderer/print_web_view_helper_browsertest.cc b/chrome/renderer/print_web_view_helper_browsertest.cc

index d784e807da282933b308887ae79db08a0539b0a7..3c362cf1c15cd04fde4141848eae3a2350899add 100644

--- a/chrome/renderer/print_web_view_helper_browsertest.cc

+++ b/chrome/renderer/print_web_view_helper_browsertest.cc

@@ -49,7 +49,7 @@ void CreatePrintSettingsDictionary(DictionaryValue* dict) {

dict->SetString(printing::kPreviewUIAddr, "0xb33fbeef");

dict->SetInteger(printing::kPreviewRequestID, 12345);

dict->SetBoolean(printing::kIsFirstRequest, true);

- dict->SetBoolean(printing::kSettingDefaultMarginsSelected, true);

+ dict->SetInteger(printing::kSettingMarginsType, printing::DEFAULT_MARGINS);

dict->SetBoolean(printing::kSettingHeaderFooterEnabled, false);

dict->SetBoolean(printing::kSettingGenerateDraftData, true);

}

« no previous file with comments | « chrome/renderer/print_web_view_helper.cc ('k') | printing/print_job_constants.h » ('j') | no next file with comments »