chrome/browser/resources/print_preview/print_preview.js - Issue 8227034: Change print setting conventions for margins to support more options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/print_preview.js

Issue 8227034: Change print setting conventions for margins to support more options. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix test compile Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/print_preview/print_preview.js

diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js

index c3bfbca1d3229bee531b733ea9491a2bae44b190..6626d2c231c45e6158e98a2ed04a0dbafc57f134 100644

--- a/chrome/browser/resources/print_preview/print_preview.js

+++ b/chrome/browser/resources/print_preview/print_preview.js

@@ -355,11 +355,13 @@ function getSettings() {

'printWithCloudPrint': printWithCloudPrint,

'isFirstRequest' : false,

'headerFooterEnabled': headerFooterSettings.hasHeaderFooter(),

- 'defaultMarginsSelected': marginSettings.isDefaultMarginsSelected(),

- 'margins': marginSettings.customMargins,

+ 'marginsType': marginSettings.selectedMarginsValue,

'requestID': -1,

'generateDraftData': generateDraftData};

+ if (marginSettings.isCustomMarginsSelected())

+ settings['marginsCustom'] = marginSettings.customMargins;

var printerList = $('printer-list');

var selectedPrinter = printerList.selectedIndex;

if (cloudprint.isCloudPrint(printerList.options[selectedPrinter])) {