Multi-Profiles: Fix choosing random profile avatar

Multi-Profiles: Fix choosing random profile avatar

The code to choose the default profile avatar had a bug where it was much more likely to pick the 9th avatar icon.

I fixed the code to make it truly random. I also refactored it so that it's much easier to reason about.

BUG=99788
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104984

[Miranda Callahan, 2011-10-11 19:08:47]

On 2011/10/11 18:54:30, sail wrote:

LGTM with some naming comments!

[sail, 2011-10-11 19:16:20]

On 2011/10/11 19:08:47, Miranda Callahan wrote:
> On 2011/10/11 18:54:30, sail wrote:
> 
> LGTM with some naming comments!

Oops, did the comments get dropped somehow?

[Miranda Callahan, 2011-10-11 19:17:51]

...and here are those comments. ;-)

http://codereview.chromium.org/8227025/diff/1/chrome/browser/profiles/profile...
File chrome/browser/profiles/profile_info_cache.cc (right):

http://codereview.chromium.org/8227025/diff/1/chrome/browser/profiles/profile...
chrome/browser/profiles/profile_info_cache.cc:63: // The first 8 icons are
gendar netural.
I would actually stick with calling these "generic" -- because the majority of
the icons are gender neutral (cupcake, horse, dog, pizza, etc.)

http://codereview.chromium.org/8227025/diff/1/chrome/browser/profiles/profile...
chrome/browser/profiles/profile_info_cache.cc:64: const size_t
kGenderNeutralCount = 8;
same: kGenericIconCount

http://codereview.chromium.org/8227025/diff/1/chrome/browser/profiles/profile...
chrome/browser/profiles/profile_info_cache.cc:260: DCHECK(false);
Are we doing DCHECK(false) instead of NOTREACHED() now?

http://codereview.chromium.org/8227025/diff/1/chrome/browser/profiles/profile...
File chrome/browser/profiles/profile_info_cache.h (right):

http://codereview.chromium.org/8227025/diff/1/chrome/browser/profiles/profile...
chrome/browser/profiles/profile_info_cache.h:93: // Returns true if the given
icon index is not in use by another other profie.
Remove other.

[sail, 2011-10-11 21:44:54]

http://codereview.chromium.org/8227025/diff/1/chrome/browser/profiles/profile...
File chrome/browser/profiles/profile_info_cache.cc (right):

http://codereview.chromium.org/8227025/diff/1/chrome/browser/profiles/profile...
chrome/browser/profiles/profile_info_cache.cc:63: // The first 8 icons are
gendar netural.
On 2011/10/11 19:17:51, Miranda Callahan wrote:
> I would actually stick with calling these "generic" -- because the majority of
> the icons are gender neutral (cupcake, horse, dog, pizza, etc.)

Done.

http://codereview.chromium.org/8227025/diff/1/chrome/browser/profiles/profile...
chrome/browser/profiles/profile_info_cache.cc:64: const size_t
kGenderNeutralCount = 8;
On 2011/10/11 19:17:51, Miranda Callahan wrote:
> same: kGenericIconCount

Done.

http://codereview.chromium.org/8227025/diff/1/chrome/browser/profiles/profile...
chrome/browser/profiles/profile_info_cache.cc:260: DCHECK(false);
On 2011/10/11 19:17:51, Miranda Callahan wrote:
> Are we doing DCHECK(false) instead of NOTREACHED() now?

Done.

[commit-bot: I haz the power, 2011-10-12 00:10:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8227025/4002

[commit-bot: I haz the power, 2011-10-12 03:04:22]

Change committed as 104984