chrome/common/extensions/extension_manifests_unittest.cc - Issue 8227021: Merge 104582 - Add support for an optional "requirements" section in extension/app manifests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_manifests_unittest.cc

Issue 8227021: Merge 104582 - Add support for an optional "requirements" section in extension/app manifests. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/874/src/

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/extension_constants.cc ('k') | chrome/test/data/extensions/manifest_tests/init_invalid_requirements_1.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_manifests_unittest.cc

===================================================================

--- chrome/common/extensions/extension_manifests_unittest.cc (revision 104911)

+++ chrome/common/extensions/extension_manifests_unittest.cc (working copy)

@@ -207,7 +207,9 @@

{"init_invalid_locale_empty.json", errors::kInvalidDefaultLocale},

{"init_invalid_min_chrome_invalid.json",

errors::kInvalidMinimumChromeVersion},

- {"init_invalid_chrome_version_too_low.json", errors::kChromeVersionTooLow}

+ {"init_invalid_chrome_version_too_low.json", errors::kChromeVersionTooLow},

+ {"init_invalid_requirements_1.json", errors::kInvalidRequirements},

+ {"init_invalid_requirements_2.json", errors::kInvalidRequirement}

};

RunTestcases(testcases, arraysize(testcases));

@@ -245,6 +247,9 @@

// Test with a minimum_chrome_version.

extension = LoadAndExpectSuccess("init_valid_minimum_chrome.json");

+ // Test a hosted app with a requirements section.

+ extension = LoadAndExpectSuccess("init_valid_app_requirements.json");

// Verify empty permission settings are considered valid.

LoadAndExpectSuccess("init_valid_permissions_empty.json");