content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 8227018: mac: Almost fix Lion accented character bubble input in web contents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 8227018: mac: Almost fix Lion accented character bubble input in web contents. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index 6c5e8f88928c4ffde982d35d4084c548ff99a53c..e0f75d69a5d977c296008e9327b664d4e5906d71 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -2478,8 +2478,9 @@ extern NSString *NSTextInputReplacementRangeAttributeName;

if (handlingKeyDown_) {

textToBeInserted_.append(base::SysNSStringToUTF16(im_text));

} else {

+ ui::Range replacement_range(replacementRange);

renderWidgetHostView_->render_widget_host_->ImeConfirmComposition(

- base::SysNSStringToUTF16(im_text));

+ base::SysNSStringToUTF16(im_text), replacement_range);

}

// Inserting text will delete all marked text automatically.

« no previous file with comments | « content/browser/renderer_host/render_widget_host.cc ('k') | content/common/view_messages.h » ('j') | no next file with comments »