Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 8227017: Add Windows manifest for views_examples. (Closed)

Created:
9 years, 2 months ago by Alexei Svitkine (slow)
Modified:
9 years, 2 months ago
CC:
chromium-reviews, tfarina, dhollowa
Visibility:
Public.

Description

Add Windows manifest for views_examples. This allows views_examples to use themed controls and fixes a problem with combo box drop down menus not being shown. Manifest file copied from chrome/app/chrome.exe.manifest. BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104939

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
A views/examples/views_examples.exe.manifest View 1 1 chunk +27 lines, -0 lines 0 comments Download
M views/views.gyp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
9 years, 2 months ago (2011-10-11 16:37:04 UTC) #1
Ben Goodger (Google)
LGTM On Tue, Oct 11, 2011 at 9:37 AM, <asvitkine@chromium.org> wrote: > Reviewers: Ben Goodger ...
9 years, 2 months ago (2011-10-11 17:58:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8227017/2001
9 years, 2 months ago (2011-10-11 18:01:10 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-11 19:34:12 UTC) #4
Change committed as 104939

Powered by Google App Engine
This is Rietveld 408576698