Make OmitFramePointer adjustable for Win/Release build.

build/common.gypi

Index: build/common.gypi
===================================================================
--- build/common.gypi	(revision 104879)
+++ build/common.gypi	(working copy)
@@ -875,14 +875,21 @@
       # See http://gcc.gnu.org/onlinedocs/gcc-4.4.2/gcc/Optimize-Options.html
       'mac_release_optimization%': '3', # Use -O3 unless overridden
       'mac_debug_optimization%': '0',   # Use -O0 unless overridden
+
       # See http://msdn.microsoft.com/en-us/library/aa652360(VS.71).aspx
       'win_release_Optimization%': '2', # 2 = /Os

[Timur Iskhodzhanov, 2011/10/11 12:18:20]

note this guy

       'win_debug_Optimization%': '0',   # 0 = /Od
+
+      # See http://msdn.microsoft.com/en-us/library/2kxx5t2c(v=vs.80).aspx
+      'win_release_OmitFramePointers%': 'true',
+
       # See http://msdn.microsoft.com/en-us/library/8wtf2dfz(VS.71).aspx
       'win_debug_RuntimeChecks%': '3',    # 3 = all checks enabled, 0 = off
+
       # See http://msdn.microsoft.com/en-us/library/47238hez(VS.71).aspx
       'win_debug_InlineFunctionExpansion%': '',    # empty = default, 0 = off,
       'win_release_InlineFunctionExpansion%': '2', # 1 = only __inline, 2 = max
+
       # VS inserts quite a lot of extra checks to algorithms like
       # std::partial_sort in Debug build which make them O(N^2)
       # instead of O(N*logN). This is particularly slow under memory
@@ -1391,6 +1398,14 @@
                 'InlineFunctionExpansion':
                   '<(win_release_InlineFunctionExpansion)',
               }],
+
+              # MSVS only accepts OmitFramePointers=true/false
+              ['win_release_OmitFramePointers==1 or win_release_OmitFramePointers=="true"', {

[Timur Iskhodzhanov, 2011/10/11 12:18:20]

I saw a few other places where a condition doesn't fit into 80 chars - I believe
this is not a big deal here?

[M-A Ruel, 2011/10/11 13:47:08]

I'd recommend to remove the or. Just settle with one format, either 1 or true,
otherwise it's a maintenance burden. Then you won't have a 80 cols issue. :)

[Timur Iskhodzhanov, 2011/10/11 13:56:01]

The reasoning was:
a) VS only supports true/false
b) all other GYP flags are 0/1
=> we should support both

On 2011/10/11 13:47:08, Marc-Antoine Ruel wrote:

[Timur Iskhodzhanov, 2011/10/11 13:56:37]

What'd you suggest?

On 2011/10/11 13:56:01, Timur Iskhodzhanov wrote:

[M-A Ruel, 2011/10/11 13:59:28]

I prefer consistency, so I'd use 0/1 and convert the value to true/false at
usage.

+                'OmitFramePointers': 'true',
+              }],
+              ['win_release_OmitFramePointers==0 or win_release_OmitFramePointers=="false"', {
+                'OmitFramePointers': 'false',
+              }],
             ],
           },
           'VCLinkerTool': {