build/internal/release_defaults.gypi - Issue 8227011: Make OmitFramePointer adjustable for Win/Release build.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/internal/release_defaults.gypi

Issue 8227011: Make OmitFramePointer adjustable for Win/Release build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 {	1 {

2 'msvs_settings': {	2 'msvs_settings': {

3 'VCCLCompilerTool': {	3 'VCCLCompilerTool': {

4 'Optimization': '2',
Timur Iskhodzhanov 2011/10/11 12:18:20 these two options are redundant since the flags ar these two options are redundant since the flags are adjustable from build/common.gypi now M-A Ruel 2011/10/11 13:47:08 So I guess release_impl_official.gypi value is ign Show quoted text On 2011/10/11 12:18:20, Timur Iskhodzhanov wrote: > these two options are redundant since the flags are adjustable from > build/common.gypi now So I guess release_impl_official.gypi value is ignored? That's concerning. Timur Iskhodzhanov 2011/10/11 13:56:01 Nope, the _impl_official value has higher priority Nope, the _impl_official value has higher priority and overrides those in build/common.gypi [as my experiment showed. Otherwise I wouldn't find out build/internal at all :) ] On 2011/10/11 13:47:08, Marc-Antoine Ruel wrote: Show quoted text > On 2011/10/11 12:18:20, Timur Iskhodzhanov wrote: > > these two options are redundant since the flags are adjustable from > > build/common.gypi now > > So I guess release_impl_official.gypi value is ignored? That's concerning.
5 'StringPooling': 'true',	4 'StringPooling': 'true',

6 'OmitFramePointers': 'true',

7 },	5 },

8 'VCLinkerTool': {	6 'VCLinkerTool': {

9 'LinkIncremental': '1',	7 'LinkIncremental': '1',

10 'OptimizeReferences': '2',	8 'OptimizeReferences': '2',

11 'EnableCOMDATFolding': '2',	9 'EnableCOMDATFolding': '2',

12 },	10 },

13 },	11 },

14 }	12 }

OLD	NEW

« build/common.gypi ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »