Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1557)

Side by Side Diff: runtime/bin/process.h

Issue 8227010: Fix deadlock in process exit handling (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments from @ager Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/builtin_in.cc ('k') | runtime/bin/process.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef BIN_PROCESS_H_ 5 #ifndef BIN_PROCESS_H_
6 #define BIN_PROCESS_H_ 6 #define BIN_PROCESS_H_
7 7
8 #include "bin/builtin.h" 8 #include "bin/builtin.h"
9 #include "bin/globals.h" 9 #include "bin/globals.h"
10 10
11 11
12 class Process { 12 class Process {
13 public: 13 public:
14 // Start a new process providing access to stdin, stdout, stderr and
15 // process exit streams.
14 static int Start(const char* path, 16 static int Start(const char* path,
15 char* arguments[], 17 char* arguments[],
16 intptr_t arguments_length, 18 intptr_t arguments_length,
17 intptr_t* in, 19 intptr_t* in,
18 intptr_t* out, 20 intptr_t* out,
19 intptr_t* err, 21 intptr_t* err,
20 intptr_t* id, 22 intptr_t* id,
21 intptr_t* exit_handler, 23 intptr_t* exit_handler,
22 char* os_error_message, 24 char* os_error_message,
23 int os_error_message_len); 25 int os_error_message_len);
24 26
27 // Kill a process with a given pid.
25 static bool Kill(intptr_t id); 28 static bool Kill(intptr_t id);
26 29
30 // Indicate that the process with the given pid has exited.
31 static void Exit(intptr_t id);
32
27 DISALLOW_ALLOCATION(); 33 DISALLOW_ALLOCATION();
28 DISALLOW_IMPLICIT_CONSTRUCTORS(Process); 34 DISALLOW_IMPLICIT_CONSTRUCTORS(Process);
29 }; 35 };
30 36
31 #endif // BIN_PROCESS_H_ 37 #endif // BIN_PROCESS_H_
OLDNEW
« no previous file with comments | « runtime/bin/builtin_in.cc ('k') | runtime/bin/process.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698