Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1596)

Side by Side Diff: runtime/bin/builtin_in.cc

Issue 8227010: Fix deadlock in process exit handling (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments from @ager Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/bin/process.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include <assert.h> 5 #include <assert.h>
6 #include <stdlib.h> 6 #include <stdlib.h>
7 #include <string.h> 7 #include <string.h>
8 8
9 #include "include/dart_api.h" 9 #include "include/dart_api.h"
10 10
(...skipping 22 matching lines...) Expand all
33 V(File_ReadByte, 1) \ 33 V(File_ReadByte, 1) \
34 V(File_WriteByte, 2) \ 34 V(File_WriteByte, 2) \
35 V(File_WriteString, 2) \ 35 V(File_WriteString, 2) \
36 V(File_ReadList, 4) \ 36 V(File_ReadList, 4) \
37 V(File_WriteList , 4) \ 37 V(File_WriteList , 4) \
38 V(File_Position, 1) \ 38 V(File_Position, 1) \
39 V(File_Length, 1) \ 39 V(File_Length, 1) \
40 V(File_Flush, 1) \ 40 V(File_Flush, 1) \
41 V(EventHandler_Start, 1) \ 41 V(EventHandler_Start, 1) \
42 V(EventHandler_SendData, 4) \ 42 V(EventHandler_SendData, 4) \
43 V(Process_Start, 8) \
43 V(Process_Kill, 2) \ 44 V(Process_Kill, 2) \
44 V(Process_Start, 8) \ 45 V(Process_Exit, 2) \
45 V(Socket_CreateConnect, 3) \ 46 V(Socket_CreateConnect, 3) \
46 V(Socket_Available, 1) \ 47 V(Socket_Available, 1) \
47 V(Socket_ReadList, 4) \ 48 V(Socket_ReadList, 4) \
48 V(Socket_WriteList, 4) \ 49 V(Socket_WriteList, 4) \
49 V(Socket_GetPort, 1) \ 50 V(Socket_GetPort, 1) \
50 V(ServerSocket_CreateBindListen, 4) \ 51 V(ServerSocket_CreateBindListen, 4) \
51 V(ServerSocket_Accept, 2) \ 52 V(ServerSocket_Accept, 2) \
52 53
53 54
54 BUILTIN_NATIVE_LIST(DECLARE_FUNCTION); 55 BUILTIN_NATIVE_LIST(DECLARE_FUNCTION);
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 148
148 149
149 void Builtin_SetNativeResolver() { 150 void Builtin_SetNativeResolver() {
150 Dart_Handle url = Dart_NewString(DartUtils::kBuiltinLibURL); 151 Dart_Handle url = Dart_NewString(DartUtils::kBuiltinLibURL);
151 Dart_Result result = Dart_LookupLibrary(url); 152 Dart_Result result = Dart_LookupLibrary(url);
152 assert(Dart_IsValidResult(result)); 153 assert(Dart_IsValidResult(result));
153 Dart_Handle builtin_lib = Dart_GetResult(result); 154 Dart_Handle builtin_lib = Dart_GetResult(result);
154 result = Dart_SetNativeResolver(builtin_lib, native_lookup); 155 result = Dart_SetNativeResolver(builtin_lib, native_lookup);
155 assert(Dart_IsValidResult(result)); 156 assert(Dart_IsValidResult(result));
156 } 157 }
OLDNEW
« no previous file with comments | « no previous file | runtime/bin/process.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698