Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 8226024: Reland 105087: PrintPreview: Fix printer color settings issues based on printer ppd/schema info. (Closed)

Created:
9 years, 2 months ago by kmadhusu
Modified:
9 years, 2 months ago
CC:
chromium-reviews, arv (Not doing code reviews), Paweł Hajdan Jr.
Visibility:
Public.

Description

Reland 105087: PrintPreview: Fix printer color settings issues based on printer ppd/schema info. Show/Hide the color options based on printer ppd/schema information. Some printers does not provide sufficient information in the printer schema/ppd regarding the color settings and they use custom advance settings to print in black & white/greyscale. In those cases, users need to print using native dialog in order to set these advance color settings. BUG=93811, 93490, 87344, 96658, 98768 TEST= Please refer to bug description. Review URL: http://codereview.chromium.org/8138020 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105217

Patch Set 1 #

Patch Set 2 : + PRINTING_EXPORT keyword #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+832 lines, -630 lines) Patch
M chrome/browser/printing/print_dialog_gtk.cc View 2 chunks +5 lines, -19 lines 0 comments Download
A chrome/browser/printing/print_system_task_proxy.h View 1 chunk +73 lines, -0 lines 0 comments Download
A chrome/browser/printing/print_system_task_proxy.cc View 1 chunk +543 lines, -0 lines 0 comments Download
A + chrome/browser/printing/print_system_task_proxy_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/print_preview/color_settings.js View 3 chunks +16 lines, -10 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.h View 3 chunks +2 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 7 chunks +11 lines, -344 lines 0 comments Download
D chrome/browser/ui/webui/print_preview_handler_unittest.cc View 1 chunk +0 lines, -222 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M printing/print_job_constants.h View 2 chunks +38 lines, -2 lines 0 comments Download
M printing/print_job_constants.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M printing/print_settings.h View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M printing/print_settings.cc View 1 chunk +96 lines, -0 lines 0 comments Download
M printing/printing_context_mac.mm View 2 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kmadhusu
9 years, 2 months ago (2011-10-12 18:13:01 UTC) #1
vandebo (ex-Chrome)
LGTM
9 years, 2 months ago (2011-10-12 18:15:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/8226024/4001
9 years, 2 months ago (2011-10-12 20:38:08 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-13 00:40:44 UTC) #4
Change committed as 105217

Powered by Google App Engine
This is Rietveld 408576698