Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: tools/testing/test_case.py

Issue 8226016: Add the ability to run tests with several sets of VM flags (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments from iposva@ Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/test_case.py
diff --git a/tools/testing/test_case.py b/tools/testing/test_case.py
index 1c4f7f0f01ea7020175eb719308ea2a45a90365b..25f0fe70ad11396b74cf9ca8b698750bab365833 100644
--- a/tools/testing/test_case.py
+++ b/tools/testing/test_case.py
@@ -24,7 +24,7 @@ class Error(Exception):
class StandardTestCase(test.TestCase):
- def __init__(self, context, path, filename, mode, arch):
+ def __init__(self, context, path, filename, mode, arch, vm_options = None):
ngeoffray 2011/10/13 07:53:24 vm_options = [] ? and then you can remove the null
Søren Gjesse 2011/10/13 08:57:07 Done.
super(StandardTestCase, self).__init__(context, path)
self.filename = filename
self.mode = mode
@@ -34,6 +34,11 @@ class StandardTestCase(test.TestCase):
for flag in context.flags:
self.run_arch.vm_options.append(flag)
+ if vm_options:
+ for vm_option in vm_options:
ngeoffray 2011/10/13 07:53:24 for flag in vm_options
Søren Gjesse 2011/10/13 08:57:07 Done.
+ if (len(vm_option) > 0):
ngeoffray 2011/10/13 07:53:24 Maybe you could avoid this len check by doing it b
Søren Gjesse 2011/10/13 08:57:07 Done.
+ self.run_arch.vm_options.append(vm_option)
+
def IsNegative(self):
return self.GetName().endswith("NegativeTest")

Powered by Google App Engine
This is Rietveld 408576698