Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: tools/testing/architecture.py

Issue 8226016: Add the ability to run tests with several sets of VM flags (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Removed code in comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/architecture.py
diff --git a/tools/testing/architecture.py b/tools/testing/architecture.py
index 7628ab2e1efb76a83baaac8f60dd816c935858db..87602f37e0fcc813266ebc6054d87c0cfee91e84 100755
--- a/tools/testing/architecture.py
+++ b/tools/testing/architecture.py
@@ -105,7 +105,6 @@ main() {
# Patterns for matching test options in .dart files.
-VM_OPTIONS_PATTERN = re.compile(r"// VMOptions=(.*)")
DART_OPTIONS_PATTERN = re.compile(r"// DartOptions=(.*)")
# Pattern for checking if the test is a web test.
@@ -146,14 +145,8 @@ class Architecture(object):
self.test = test;
self.build_root = utils.GetBuildRoot(OS_GUESS, self.mode, self.arch)
source = file(test).read()
- self.vm_options = utils.ParseTestOptions(VM_OPTIONS_PATTERN,
- source,
- root_path)
- if not self.vm_options: self.vm_options = []
-
- self.dart_options = utils.ParseTestOptions(DART_OPTIONS_PATTERN,
- source,
- root_path)
+ self.vm_options = []
+ self.dart_options = []
self.is_web_test = IsWebTest(test, source)
self.temp_dir = None
@@ -380,7 +373,7 @@ class StandaloneArchitecture(Architecture):
def RunTest(self, verbose):
command = self.GetRunCommand()
- return ExecuteCommand(command, verbose)
+ return ExeuteCommand(command, verbose)
Ivan Posva 2011/10/13 07:17:34 ?
Søren Gjesse 2011/10/13 07:28:15 Accidental edit.
def Cleanup(self):
return
@@ -448,4 +441,3 @@ def GetArchitecture(arch, mode, test):
elif arch == 'dartc':
return DartcArchitecture(root_path, arch, mode, test)
-

Powered by Google App Engine
This is Rietveld 408576698