Rollback r4734 to see if it fixes the crashing I experience when starting chr...

site_scons/site_tools/visual_studio_solution.py

 #!/usr/bin/python2.4
 # Copyright 2008, Google Inc.
 # All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
@@ skipping 53 matching lines @@
 
   # Add in the msvs tool.
   env.Tool('msvs')
 
   # Pick out variants
   variants = [e['BUILD_TYPE'] for e in environments]
   # Pick out build targets
   build_targets = [e.subst('$TARGET_ROOT') for e in environments]
   # pick out sources, headers, and resources
   sources, headers, resources, others = env.GatherInputs(
-      [env.Dir('$DESTINATION_ROOT')],
+      [SCons.Script.Dir('$DESTINATION_ROOT')],
       ['.+\\.(c|cc|m|mm|cpp)$',  # source files
        '.+\\.(h|hh|hpp)$',       # header files
        '.+\\.(rc)$',             # resource files
        '.*'],                    # all other files
       exclude_pattern=exclude_pattern,
   )
   # Build main Visual Studio Project file
   project_list = env.MSVSProject(target=solution_name +
                                  env['MSVSPROJECTSUFFIX'],
                                  srcs=sources + headers + others + resources,
@@ skipping 37 matching lines @@
 
 def generate(env):
   # NOTE: SCons requires the use of this name, which fails gpylint.
   """SCons entry point for this tool."""
 
   # Add in the gather_inputs tool.
   env.Tool('gather_inputs')
 
   # Add a method to generate a combined solution file.
   env.AddMethod(Solution, 'Solution')