Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9123)

Unified Diff: chrome/test/base/browser_with_test_window_test.h

Issue 8224023: Don't show URL for pending new navigations initiated by the renderer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add IsBrowserInitiated helper. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/browser_with_test_window_test.h
diff --git a/chrome/test/base/browser_with_test_window_test.h b/chrome/test/base/browser_with_test_window_test.h
index 4f329796de0dadfef19f7e4897d5dc81e5445512..7072e6756802decb2a807d5ccb60be2aec3c55a9 100644
--- a/chrome/test/base/browser_with_test_window_test.h
+++ b/chrome/test/base/browser_with_test_window_test.h
@@ -19,13 +19,13 @@ class NavigationController;
// Base class for browser based unit tests. BrowserWithTestWindowTest creates a
// Browser with a TestingProfile and TestBrowserWindow. To add a tab use
-// AddTestingTab. For example, the following adds a tab and navigates to
+// AddTab. For example, the following adds a tab and navigates to
// two URLs that target the TestTabContents:
//
// // Add a new tab and navigate it. This will be at index 0.
// AddTab(browser(), GURL("http://foo/1"));
// NavigationController* controller =
-// browser()->GetTabContentsAt(0)->controller();
+// &browser()->GetTabContentsAt(0)->controller();
//
// // Navigate somewhere else.
// GURL url2("http://foo/2");
@@ -34,7 +34,7 @@ class NavigationController;
// // This is equivalent to the above, and lets you test pending navigations.
// browser()->OpenURL(GURL("http://foo/2"), GURL(), CURRENT_TAB,
// PageTransition::TYPED);
-// CommitPendingLoadAsNewNavigation(controller, url2);
+// CommitPendingLoad(controller);
//
// Subclasses must invoke BrowserWithTestWindowTest::SetUp as it is responsible
// for creating the various objects of this class.

Powered by Google App Engine
This is Rietveld 408576698