chrome/browser/rlz/rlz_unittest.cc - Issue 8224023: Don't show URL for pending new navigations initiated by the renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/rlz/rlz_unittest.cc

Issue 8224023: Don't show URL for pending new navigations initiated by the renderer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix merge conflicts. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/rlz/rlz_unittest.cc

diff --git a/chrome/browser/rlz/rlz_unittest.cc b/chrome/browser/rlz/rlz_unittest.cc

index 020f2322c05e52d7521175fc71c5263090e15877..603f26d97cd7d91e56d3981a75a6d93a6c99f0a0 100644

--- a/chrome/browser/rlz/rlz_unittest.cc

+++ b/chrome/browser/rlz/rlz_unittest.cc

@@ -206,7 +206,7 @@ void RlzLibTest::SimulateOmniboxUsage() {

void RlzLibTest::SimulateHomepageUsage() {

NavigationEntry entry(NULL, 0, GURL(), GURL(), string16(),

- content::PAGE_TRANSITION_HOME_PAGE);

+ content::PAGE_TRANSITION_HOME_PAGE, false);

tracker_.Observe(content::NOTIFICATION_NAV_ENTRY_PENDING,

NotificationService::AllSources(),

Details<NavigationEntry>(&entry));

@@ -541,7 +541,7 @@ TEST_F(RlzLibTest, PingUpdatesRlzCache) {

TEST_F(RlzLibTest, ObserveHandlesBadArgs) {

NavigationEntry entry(NULL, 0, GURL(), GURL(), string16(),

- content::PAGE_TRANSITION_LINK);

+ content::PAGE_TRANSITION_LINK, false);

tracker_.Observe(content::NOTIFICATION_NAV_ENTRY_PENDING,

NotificationService::AllSources(),

Details<NavigationEntry>(NULL));