chrome/browser/ui/gtk/view_id_util_browsertest.cc - Issue 8224023: Don't show URL for pending new navigations initiated by the renderer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/gtk/view_id_util_browsertest.cc

Issue 8224023: Don't show URL for pending new navigations initiated by the renderer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix merge conflicts. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include <gtk/gtk.h>	5 #include <gtk/gtk.h>

6	6

7 #include "chrome/browser/ui/browser.h"	7 #include "chrome/browser/ui/browser.h"

8 #include "chrome/browser/ui/browser_window.h"	8 #include "chrome/browser/ui/browser_window.h"

9 #include "chrome/browser/ui/gtk/view_id_util.h"	9 #include "chrome/browser/ui/gtk/view_id_util.h"

10 #include "chrome/common/url_constants.h"	10 #include "chrome/common/url_constants.h"

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49 }	49 }

50	50

51 CheckViewID(VIEW_ID_PREDEFINED_COUNT, false);	51 CheckViewID(VIEW_ID_PREDEFINED_COUNT, false);

52 }	52 }

53	53

54 IN_PROC_BROWSER_TEST_F(ViewIDTest, Delegate) {	54 IN_PROC_BROWSER_TEST_F(ViewIDTest, Delegate) {

55 CheckViewID(VIEW_ID_TAB_0, true);	55 CheckViewID(VIEW_ID_TAB_0, true);

56 CheckViewID(VIEW_ID_TAB_1, false);	56 CheckViewID(VIEW_ID_TAB_1, false);

57	57

58 browser()->OpenURL(OpenURLParams(GURL(chrome::kAboutBlankURL), GURL(),	58 browser()->OpenURL(OpenURLParams(GURL(chrome::kAboutBlankURL), GURL(),

59 NEW_BACKGROUND_TAB, content::PAGE_TRANSITION_TYPED));	59 NEW_BACKGROUND_TAB, content::PAGE_TRANSITION_TYPED,

	60 false));

60	61

61 CheckViewID(VIEW_ID_TAB_0, true);	62 CheckViewID(VIEW_ID_TAB_0, true);

62 CheckViewID(VIEW_ID_TAB_1, true);	63 CheckViewID(VIEW_ID_TAB_1, true);

63 }	64 }

OLD	NEW