chrome/browser/ui/gtk/sad_tab_gtk.cc - Issue 8224023: Don't show URL for pending new navigations initiated by the renderer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/gtk/sad_tab_gtk.cc

Issue 8224023: Don't show URL for pending new navigations initiated by the renderer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix merge conflicts. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/gtk/page_info_bubble_gtk.cc ('k') | chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/gtk/sad_tab_gtk.h"	5 #include "chrome/browser/ui/gtk/sad_tab_gtk.h"

6	6

7 #include "base/utf_string_conversions.h"	7 #include "base/utf_string_conversions.h"

8 #include "chrome/browser/google/google_util.h"	8 #include "chrome/browser/google/google_util.h"

9 #include "chrome/browser/ui/gtk/gtk_chrome_link_button.h"	9 #include "chrome/browser/ui/gtk/gtk_chrome_link_button.h"

10 #include "chrome/common/url_constants.h"	10 #include "chrome/common/url_constants.h"

(...skipping 143 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
154 }	154 }

155	155

156 void SadTabGtk::OnLinkButtonClick(GtkWidget* sender) {	156 void SadTabGtk::OnLinkButtonClick(GtkWidget* sender) {

157 if (tab_contents_ != NULL) {	157 if (tab_contents_ != NULL) {

158 GURL help_url =	158 GURL help_url =

159 google_util::AppendGoogleLocaleParam(GURL(	159 google_util::AppendGoogleLocaleParam(GURL(

160 kind_ == CRASHED ?	160 kind_ == CRASHED ?

161 chrome::kCrashReasonURL :	161 chrome::kCrashReasonURL :

162 chrome::kKillReasonURL));	162 chrome::kKillReasonURL));

163 tab_contents_->OpenURL(OpenURLParams(	163 tab_contents_->OpenURL(OpenURLParams(

164 help_url, GURL(), CURRENT_TAB, content::PAGE_TRANSITION_LINK));	164 help_url, GURL(), CURRENT_TAB, content::PAGE_TRANSITION_LINK, false));

165 }	165 }

166 }	166 }

OLD	NEW