Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: chrome/browser/ui/gtk/global_bookmark_menu.cc

Issue 8224023: Don't show URL for pending new navigations initiated by the renderer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix merge conflicts. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/global_bookmark_menu.h" 5 #include "chrome/browser/ui/gtk/global_bookmark_menu.h"
6 6
7 #include <dlfcn.h> 7 #include <dlfcn.h>
8 #include <gtk/gtk.h> 8 #include <gtk/gtk.h>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 RebuildMenuInFuture(); 256 RebuildMenuInFuture();
257 } 257 }
258 258
259 void GlobalBookmarkMenu::OnBookmarkItemActivated(GtkWidget* menu_item) { 259 void GlobalBookmarkMenu::OnBookmarkItemActivated(GtkWidget* menu_item) {
260 // The actual mouse event that generated this activated event was in a 260 // The actual mouse event that generated this activated event was in a
261 // different process. Go with something default. 261 // different process. Go with something default.
262 const BookmarkNode* node = static_cast<const BookmarkNode*>( 262 const BookmarkNode* node = static_cast<const BookmarkNode*>(
263 g_object_get_data(G_OBJECT(menu_item), "bookmark-node")); 263 g_object_get_data(G_OBJECT(menu_item), "bookmark-node"));
264 264
265 browser_->OpenURL(OpenURLParams(node->url(), GURL(), NEW_FOREGROUND_TAB, 265 browser_->OpenURL(OpenURLParams(node->url(), GURL(), NEW_FOREGROUND_TAB,
266 content::PAGE_TRANSITION_AUTO_BOOKMARK)); 266 content::PAGE_TRANSITION_AUTO_BOOKMARK, false));
267 } 267 }
268 268
OLDNEW
« no previous file with comments | « chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc ('k') | chrome/browser/ui/gtk/global_history_menu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698