Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

Issue 8224023: Don't show URL for pending new navigations initiated by the renderer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix merge conflicts. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <gtk/gtk.h> 5 #include <gtk/gtk.h>
6 6
7 #include "base/string_util.h" 7 #include "base/string_util.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/browser/extensions/extension_install_dialog.h" 9 #include "chrome/browser/extensions/extension_install_dialog.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 } 219 }
220 220
221 gtk_widget_destroy(dialog_); 221 gtk_widget_destroy(dialog_);
222 delete this; 222 delete this;
223 } 223 }
224 224
225 void ExtensionInstallDialog::OnStoreLinkClick(GtkWidget* sender) { 225 void ExtensionInstallDialog::OnStoreLinkClick(GtkWidget* sender) {
226 GURL store_url( 226 GURL store_url(
227 extension_urls::GetWebstoreItemDetailURLPrefix() + extension_->id()); 227 extension_urls::GetWebstoreItemDetailURLPrefix() + extension_->id());
228 BrowserList::GetLastActive()->OpenURL(OpenURLParams( 228 BrowserList::GetLastActive()->OpenURL(OpenURLParams(
229 store_url, GURL(), NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK)); 229 store_url, GURL(), NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK,
230 false));
230 231
231 OnResponse(dialog_, GTK_RESPONSE_CLOSE); 232 OnResponse(dialog_, GTK_RESPONSE_CLOSE);
232 } 233 }
233 234
234 } // namespace 235 } // namespace
235 236
236 void ShowExtensionInstallDialog( 237 void ShowExtensionInstallDialog(
237 Profile* profile, 238 Profile* profile,
238 ExtensionInstallUI::Delegate* delegate, 239 ExtensionInstallUI::Delegate* delegate,
239 const Extension* extension, 240 const Extension* extension,
(...skipping 11 matching lines...) Expand all
251 delegate->InstallUIAbort(false); 252 delegate->InstallUIAbort(false);
252 return; 253 return;
253 } 254 }
254 255
255 new ExtensionInstallDialog(browser_window->window(), 256 new ExtensionInstallDialog(browser_window->window(),
256 delegate, 257 delegate,
257 extension, 258 extension,
258 icon, 259 icon,
259 prompt); 260 prompt);
260 } 261 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc ('k') | chrome/browser/ui/gtk/global_bookmark_menu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698