Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: content/content_plugin.gypi

Issue 8224021: Move the following files to content\public\plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/content_plugin.gypi
===================================================================
--- content/content_plugin.gypi (revision 104808)
+++ content/content_plugin.gypi (working copy)
@@ -14,11 +14,10 @@
'sources': [
# All .cc, .h, .m, and .mm files under plugins except for tests and
# mocks.
- 'plugin/content_plugin_client.h',
'plugin/plugin_channel.cc',
'plugin/plugin_channel.h',
+ 'plugin/plugin_interpose_util_mac.h',
'plugin/plugin_interpose_util_mac.mm',
- 'plugin/plugin_interpose_util_mac.h',
'plugin/plugin_main.cc',
'plugin/plugin_main_linux.cc',
'plugin/plugin_main_mac.mm',
@@ -30,6 +29,7 @@
'plugin/webplugin_delegate_stub.h',
'plugin/webplugin_proxy.cc',
'plugin/webplugin_proxy.h',
+ 'public/plugin/content_plugin_client.h',
],
# These are layered in conditionals in the event other platforms
# end up using this module as well.
@@ -49,5 +49,49 @@
],
},
}],
+ ['OS=="mac"', {
+ 'targets': [
+ {
+ # dylib for interposing Carbon calls in the plugin process.
+ 'target_name': 'plugin_carbon_interpose',
+ 'type': 'shared_library',
+ 'dependencies': [
+ 'chrome_dll',
jam 2011/10/11 02:08:39 it's a layering violation that a module in content
Avi (use Gerrit) 2011/10/11 15:58:22 As I mentioned, you should bring the carbon interp
Mark Mentovai 2011/10/11 18:26:02 Avi wrote:
+ ],
+ 'sources': [
+ 'plugin/plugin_carbon_interpose_mac.cc',
+ ],
+ 'include_dirs': [
+ '..',
+ ],
+ 'link_settings': {
+ 'libraries': [
+ '$(SDKROOT)/System/Library/Frameworks/Carbon.framework',
+ ],
+ },
+ 'xcode_settings': {
+ 'DYLIB_COMPATIBILITY_VERSION': '<(version_mac_dylib)',
+ 'DYLIB_CURRENT_VERSION': '<(version_mac_dylib)',
+ 'DYLIB_INSTALL_NAME_BASE': '@executable_path/../../..',
+ },
+ 'postbuilds': [
+ {
+ # The framework (chrome_dll) defines its load-time path
+ # (DYLIB_INSTALL_NAME_BASE) relative to the main executable
+ # (chrome). A different relative path needs to be used in
+ # plugin_carbon_interpose, which runs in the helper_app.
+ 'postbuild_name': 'Fix Framework Link',
+ 'action': [
+ 'install_name_tool',
+ '-change',
+ '@executable_path/../Versions/<(version_full)/<(mac_product_name) Framework.framework/<(mac_product_name) Framework',
jam 2011/10/11 02:08:39 nit: i don't know what this code is, but will this
Mark Mentovai 2011/10/11 18:26:02 John Abd-El-Malek wrote:
+ '@executable_path/../../../<(mac_product_name) Framework.framework/<(mac_product_name) Framework',
+ '${BUILT_PRODUCTS_DIR}/${EXECUTABLE_PATH}'
+ ],
+ },
+ ],
+ },
+ ]
+ }]
],
}

Powered by Google App Engine
This is Rietveld 408576698