Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 8224001: Prepare push to trunk. We are now working on 3.6.7. (Closed)

Created:
9 years, 2 months ago by Sven Panne
Modified:
9 years, 2 months ago
Reviewers:
Rico, danno
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. We are now working on 3.6.7. Committed: http://code.google.com/p/v8/source/detail?r=9567

Patch Set 1 #

Total comments: 16

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M ChangeLog View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
9 years, 2 months ago (2011-10-10 11:14:05 UTC) #1
Rico
Drive by: Please use past tense for ChangeLog entries http://codereview.chromium.org/8224001/diff/1/ChangeLog File ChangeLog (right): http://codereview.chromium.org/8224001/diff/1/ChangeLog#newcode5 ChangeLog:5: ...
9 years, 2 months ago (2011-10-10 11:25:43 UTC) #2
Sven Panne
http://codereview.chromium.org/8224001/diff/1/ChangeLog File ChangeLog (right): http://codereview.chromium.org/8224001/diff/1/ChangeLog#newcode5 ChangeLog:5: Simplify calling generated code from the runtime. On 2011/10/10 ...
9 years, 2 months ago (2011-10-10 11:34:54 UTC) #3
danno
9 years, 2 months ago (2011-10-10 11:35:52 UTC) #4
LGTM with nits.

http://codereview.chromium.org/8224001/diff/4001/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/8224001/diff/4001/ChangeLog#newcode5
ChangeLog:5: Add presubmit=no and werror=no flags to Makefile.
Added

http://codereview.chromium.org/8224001/diff/4001/ChangeLog#newcode9
ChangeLog:9: Make GCC 4.5.x happy. (issue 1743)
Perhaps "Fixed compilation issues with GCC 4.5.x" might be better? ;-)

Powered by Google App Engine
This is Rietveld 408576698