Print Preview: Keep the cancel button enabled whenever possible. Hook up the escape key to cancel.

chrome/browser/resources/print_preview/print_preview.js

Index: chrome/browser/resources/print_preview/print_preview.js
===================================================================
--- chrome/browser/resources/print_preview/print_preview.js	(revision 104750)
+++ chrome/browser/resources/print_preview/print_preview.js	(working copy)
@@ -53,6 +53,9 @@
 // True when preview tab is hidden.
 var isTabHidden = false;
 
+// Object holding the print and cancel buttons.
+var printHeader;
+
 // Object holding all the pages related settings.
 var pageSettings;
 
@@ -104,6 +107,9 @@
   initialPreviewRequestID = randomInteger(MIN_REQUEST_ID, MAX_REQUEST_ID);
   lastPreviewRequestID = initialPreviewRequestID;
 
+  printHeader = print_preview.PrintHeader.getInstance();
+  printHeader.addEventListeners();
+
   if (!checkCompatiblePluginExists()) {
     disableInputElementsInSidebar();
     displayErrorMessageWithButton(localStrings.getString('noPlugin'),
@@ -118,14 +124,12 @@
 
   $('printer-list').disabled = true;
 
-  printHeader = print_preview.PrintHeader.getInstance();
   pageSettings = print_preview.PageSettings.getInstance();
   copiesSettings = print_preview.CopiesSettings.getInstance();
   layoutSettings = print_preview.LayoutSettings.getInstance();
   marginSettings = print_preview.MarginSettings.getInstance();
   headerFooterSettings = print_preview.HeaderFooterSettings.getInstance();
   colorSettings = print_preview.ColorSettings.getInstance();
-  printHeader.addEventListeners();
   pageSettings.addEventListeners();
   copiesSettings.addEventListeners();
   headerFooterSettings.addEventListeners();
@@ -144,8 +148,11 @@
  */
 function disableInputElementsInSidebar() {
   var els = $('sidebar').querySelectorAll('input, button, select');
-  for (var i = 0; i < els.length; i++)
+  for (var i = 0; i < els.length; i++) {
+    if (els[i] == printHeader.cancelButton)
+      continue;
     els[i].disabled = true;
+  }
 }
 
 /**
@@ -170,6 +177,7 @@
     return;
   showingSystemDialog = true;
   $('error-button').disabled = true;
+  cr.dispatchSimpleEvent(document, 'disableCancelButton');
   $('native-print-dialog-throbber').classList.remove('hidden');
   chrome.send('showSystemDialog');
 }
@@ -892,7 +900,7 @@
 }
 
 /**
- * Checks to see if the requested print data is available for printing  and
+ * Checks to see if the requested print data is available for printing and
  * sends a print document request if needed.
  */
 function sendPrintDocumentRequestIfNeeded() {
@@ -1022,7 +1030,28 @@
       'printPreviewTitleFormat', initiatorTabTitle);
 }
 
+/**
+ * Closes this print preview tab.
+ */
+function closePrintPreviewTab() {
+  chrome.send('closePrintPreviewTab');
+}
+
+/**
+  * Handle keyboard events.
+  * @param {Event} e The keyboard event.
+  */
+function onKeyDown(e) {
+  // Escape key closes the dialog.
+  if (e.keyCode == 27 && !e.shiftKey && !e.ctrlKey && !e.altKey && !e.metaKey) {
+    cr.dispatchSimpleEvent(document, 'disableCancelButton');

[dpapad, 2011/10/10 19:53:24]

Is it necessary to disable the cancel button here, since the tab is going to
close anyway?

[Lei Zhang, 2011/10/10 20:03:14]

Not sure. If the user presses escape many times quickly, is it possible for the
JS to call closePrintPreviewTab() twice? I'm just trying to play it safe.

+    closePrintPreviewTab();
+    return

[dpapad, 2011/10/10 19:53:24]

Nit: semicolon.

[Lei Zhang, 2011/10/10 20:03:14]

Done.

+  }
+}
+
 window.addEventListener('DOMContentLoaded', onLoad);
+window.addEventListener('keydown', onKeyDown);
 
 /// Pull in all other scripts in a single shot.
 <include src="print_preview_animations.js"/>