Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Side by Side Diff: src/type-info.cc

Issue 8223001: Fix presubmit error. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 390 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 } 401 }
402 402
403 403
404 void TypeFeedbackOracle::CollectReceiverTypes(unsigned ast_id, 404 void TypeFeedbackOracle::CollectReceiverTypes(unsigned ast_id,
405 Handle<String> name, 405 Handle<String> name,
406 Code::Flags flags, 406 Code::Flags flags,
407 SmallMapList* types) { 407 SmallMapList* types) {
408 Handle<Object> object = GetInfo(ast_id); 408 Handle<Object> object = GetInfo(ast_id);
409 if (object->IsUndefined() || object->IsSmi()) return; 409 if (object->IsUndefined() || object->IsSmi()) return;
410 410
411 if (*object == isolate_->builtins()->builtin(Builtins::kStoreIC_GlobalProxy)) { 411 if (*object ==
412 isolate_->builtins()->builtin(Builtins::kStoreIC_GlobalProxy)) {
412 // TODO(fschneider): We could collect the maps and signal that 413 // TODO(fschneider): We could collect the maps and signal that
413 // we need a generic store (or load) here. 414 // we need a generic store (or load) here.
414 ASSERT(Handle<Code>::cast(object)->ic_state() == MEGAMORPHIC); 415 ASSERT(Handle<Code>::cast(object)->ic_state() == MEGAMORPHIC);
415 } else if (object->IsMap()) { 416 } else if (object->IsMap()) {
416 types->Add(Handle<Map>::cast(object)); 417 types->Add(Handle<Map>::cast(object));
417 } else if (Handle<Code>::cast(object)->ic_state() == MEGAMORPHIC) { 418 } else if (Handle<Code>::cast(object)->ic_state() == MEGAMORPHIC) {
418 types->Reserve(4); 419 types->Reserve(4);
419 ASSERT(object->IsCode()); 420 ASSERT(object->IsCode());
420 isolate_->stub_cache()->CollectMatchingMaps(types, *name, flags); 421 isolate_->stub_cache()->CollectMatchingMaps(types, *name, flags);
421 } 422 }
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
560 USE(maybe_result); 561 USE(maybe_result);
561 #ifdef DEBUG 562 #ifdef DEBUG
562 Object* result = NULL; 563 Object* result = NULL;
563 // Dictionary has been allocated with sufficient size for all elements. 564 // Dictionary has been allocated with sufficient size for all elements.
564 ASSERT(maybe_result->ToObject(&result)); 565 ASSERT(maybe_result->ToObject(&result));
565 ASSERT(*dictionary_ == result); 566 ASSERT(*dictionary_ == result);
566 #endif 567 #endif
567 } 568 }
568 569
569 } } // namespace v8::internal 570 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698