Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: webkit/plugins/ppapi/plugin_module.h

Issue 8222021: Prevent reentrant destructors in the PluginModule. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/host_dispatcher.cc ('k') | webkit/plugins/ppapi/plugin_module.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/plugin_module.h
===================================================================
--- webkit/plugins/ppapi/plugin_module.h (revision 104693)
+++ webkit/plugins/ppapi/plugin_module.h (working copy)
@@ -138,6 +138,7 @@
// release relevant resources and update all affected instances.
void PluginCrashed();
+ bool is_in_destructor() const { return is_in_destructor_; }
bool is_crashed() const { return is_crashed_; }
// Reserves the given instance is unique within the plugin, checking for
@@ -173,6 +174,10 @@
PP_Module pp_module_;
+ // True when we're running in the destructor. This allows us to write some
+ // assertions.
+ bool is_in_destructor_;
+
// True if the plugin is running out-of-process and has crashed.
bool is_crashed_;
« no previous file with comments | « ppapi/proxy/host_dispatcher.cc ('k') | webkit/plugins/ppapi/plugin_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698