Prevent reentrant destructors in the PluginModule.

webkit/plugins/ppapi/plugin_module.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_PLUGINS_PPAPI_PLUGIN_MODULE_H_
 #define WEBKIT_PLUGINS_PPAPI_PLUGIN_MODULE_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 120 matching lines @@
   // releases us in its destructor.
   void InstanceCreated(PluginInstance* instance);
   void InstanceDeleted(PluginInstance* instance);
 
   scoped_refptr<CallbackTracker> GetCallbackTracker();
 
   // Called when running out of process and the plugin crashed. This will
   // release relevant resources and update all affected instances.
   void PluginCrashed();
 
+  bool is_in_destructor() const { return is_in_destructor_; }
   bool is_crashed() const { return is_crashed_; }
 
   // Reserves the given instance is unique within the plugin, checking for
   // collisions. See PPB_Proxy_Private for more information.
   //
   // The setter will set the callback which is set up when the proxy
   // initializes. The Reserve function will call the previously set callback if
   // it exists to validate the ID. If the callback has not been set (such as
   // for in-process plugins), the Reserve function will assume that the ID is
   // usable and will return true.
@@ skipping 15 matching lines @@
   bool InitializeModule(const EntryPoints& entry_points);
 
   PluginDelegate::ModuleLifetime* lifetime_delegate_;
 
   // Tracker for completion callbacks, used mainly to ensure that all callbacks
   // are properly aborted on module shutdown.
   scoped_refptr<CallbackTracker> callback_tracker_;
 
   PP_Module pp_module_;
 
+  // True when we're running in the destructor. This allows us to write some
+  // assertions.
+  bool is_in_destructor_;
+
   // True if the plugin is running out-of-process and has crashed.
   bool is_crashed_;
 
   // Manages the out of process proxy interface. The presence of this
   // pointer indicates that the plugin is running out of process and that the
   // entry_points_ aren't valid.
   scoped_ptr<PluginDelegate::OutOfProcessProxy> out_of_process_proxy_;
 
   // Non-owning pointer to the broker for this plugin module, if one exists.
   // It is populated and cleared in the main thread.
@@ skipping 24 matching lines @@
   // Lazily created by GetWebKitForwarding.
   scoped_ptr< ::ppapi::WebKitForwarding> webkit_forwarding_;
 
   DISALLOW_COPY_AND_ASSIGN(PluginModule);
 };
 
 }  // namespace ppapi
 }  // namespace webkit
 
 #endif  // WEBKIT_PLUGINS_PPAPI_PLUGIN_MODULE_H_