Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 8222021: Prevent reentrant destructors in the PluginModule. (Closed)

Created:
9 years, 2 months ago by brettw
Modified:
9 years, 2 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Prevent reentrant destructors in the PluginModule. This makes us not hold a ref to the PluginModule during sending async messages. Previously we would cancel callbacks in the PluginModule destructor and this would change the ref count from 0 to 1, and then back to 0, calling reentrantly into the destructor again. Not holding a ref during async messages prevent this problem. I also added some checking to detect sync messages during shutdown, and also reentrant destructors should this happen again. BUG = http://crosbug.com/21258, http://crbug.com/99398 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104847

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -13 lines) Patch
M ppapi/c/private/ppb_proxy_private.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M ppapi/proxy/host_dispatcher.cc View 1 chunk +19 lines, -7 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 3 chunks +16 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/ppb_proxy_impl.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
9 years, 2 months ago (2011-10-10 23:35:39 UTC) #1
viettrungluu
9 years, 2 months ago (2011-10-10 23:39:17 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698