Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 8222009: Revert 91125 - 2011-07-15 Rob Buis <rbuis@rim.com> (Closed)

Created:
9 years, 2 months ago by dglazkov
Modified:
9 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Revert 91125 - 2011-07-15 Rob Buis <rbuis@rim.com>; Stroking of zero-length paths in SVG should change according to erratum https://bugs.webkit.org/show_bug.cgi?id=18356 Reviewed by Nikolas Zimmermann. Ensure rendering of zero-length paths with stroke-linecap=square works by creating the square rectangle manually. Tests: svg/W3C-SVG-1.1-SE/painting-control-04-f.svg svg/custom/zero-path-square-cap-rendering.svg * platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextStateSaver::context): * rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::strokeContains): (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath): (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::setupSquareCapPath): (WebCore::RenderSVGPath::setupNonScalingStrokePath): (WebCore::RenderSVGPath::fillAndStrokePath): (WebCore::RenderSVGPath::updateCachedBoundaries): * rendering/svg/RenderSVGPath.h: TBR=rwlbuis@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -85 lines) Patch
D LayoutTests/svg/custom/zero-path-square-cap-rendering.svg View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/platform/graphics/GraphicsContext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGPath.h View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGPath.cpp View 4 chunks +15 lines, -74 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dglazkov
9 years, 2 months ago (2011-10-10 16:36:46 UTC) #1
Nico
9 years, 2 months ago (2011-10-10 16:50:00 UTC) #2
LGTM, thanks

Powered by Google App Engine
This is Rietveld 408576698