Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 8222008: Ups the size of the desktop window that is created so tests pass. We (Closed)

Created:
9 years, 2 months ago by sky
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Ups the size of the desktop window that is created so tests pass. We likely want to provide a test DesktopHost implementation for the tests, but this makes a test pass for now. Also, adds aura_shell_unittests to all.gyp. BUG=none TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104742

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/aura_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
9 years, 2 months ago (2011-10-10 16:32:07 UTC) #1
Ben Goodger (Google)
9 years, 2 months ago (2011-10-10 16:42:09 UTC) #2
LGTM.

On Mon, Oct 10, 2011 at 9:32 AM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Ups the size of the desktop window that is created so tests pass. We
> likely want to provide a test DesktopHost implementation for the
> tests, but this makes a test pass for now. Also, adds
> aura_shell_unittests to all.gyp.
>
> BUG=none
> TEST=none
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/8222008/<http://codereview.chromium.org/8222...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M build/all.gyp
>  M ui/aura/aura_test_base.cc
>
>
> Index: build/all.gyp
> diff --git a/build/all.gyp b/build/all.gyp
> index 4671f6579666a3ff38a83e03550e71**c0a6d06dd9..**
> f3995c44b3b9d84b8a65d9748610dc**52d23035e2 100644
> --- a/build/all.gyp
> +++ b/build/all.gyp
> @@ -606,6 +606,7 @@
>           'dependencies': [
>             '../chrome/chrome.gyp:chrome',
>             '../ui/aura_shell/aura_shell.**gyp:aura_shell_exe',
> +            '../ui/aura_shell/aura_shell.**gyp:aura_shell_unittests',
>             '../ui/aura/aura.gyp:*',
>             '../ui/gfx/compositor/**compositor.gyp:*',
>             '../views/views.gyp:views',
> Index: ui/aura/aura_test_base.cc
> diff --git a/ui/aura/aura_test_base.cc b/ui/aura/aura_test_base.cc
> index aefeea142edc6486db08f4607bbb83**be70fbecbd..**
> 9d3e5477fb7985be3869b95ca26b1a**80f3aea2d0 100644
> --- a/ui/aura/aura_test_base.cc
> +++ b/ui/aura/aura_test_base.cc
> @@ -43,7 +43,7 @@ void AuraTestBase::SetUp() {
>   // TestDesktopDelegate is owned by the desktop.
>   new TestDesktopDelegate();
>   Desktop::GetInstance()->Show()**;
> -  Desktop::GetInstance()->**SetSize(gfx::Size(500, 500));
> +  Desktop::GetInstance()->**SetSize(gfx::Size(600, 600));
>  }
>
>  void AuraTestBase::TearDown() {
>
>
>

Powered by Google App Engine
This is Rietveld 408576698