chrome/browser/ui/views/location_bar/location_bar_view.cc - Issue 8221027: Make views::Label and views::Link auto-color themselves to be readable over their background colo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 8221027: Make views::Label and views::Link auto-color themselves to be readable over their background colo... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/keyword_hint_view.cc ('k') | chrome/browser/ui/views/location_bar/suggested_text_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_bar_view.cc

===================================================================

--- chrome/browser/ui/views/location_bar/location_bar_view.cc (revision 104959)

+++ chrome/browser/ui/views/location_bar/location_bar_view.cc (working copy)

@@ -217,13 +217,10 @@

selected_keyword_view_->SetFont(font_);

selected_keyword_view_->SetVisible(false);

- SkColor dimmed_text = GetColor(ToolbarModel::NONE, DEEMPHASIZED_TEXT);

keyword_hint_view_ = new KeywordHintView(profile);

AddChildView(keyword_hint_view_);

keyword_hint_view_->SetVisible(false);

keyword_hint_view_->SetFont(font_);

- keyword_hint_view_->SetColor(dimmed_text);

for (int i = 0; i < CONTENT_SETTINGS_NUM_TYPES; ++i) {

ContentSettingImageView* content_blocked_view =

@@ -431,10 +428,6 @@

if (!text.empty()) {

if (!suggested_text_view_) {

suggested_text_view_ = new SuggestedTextView(location_entry_->model());

- suggested_text_view_->SetHorizontalAlignment(views::Label::ALIGN_LEFT);

- suggested_text_view_->SetColor(

- GetColor(ToolbarModel::NONE,

- LocationBarView::DEEMPHASIZED_TEXT));

suggested_text_view_->SetText(text);

if (views::Widget::IsPureViews())

NOTIMPLEMENTED();