Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: chrome/browser/chromeos/login/new_user_view.h

Issue 8221027: Make views::Label and views::Link auto-color themselves to be readable over their background colo... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/new_user_view.h
===================================================================
--- chrome/browser/chromeos/login/new_user_view.h (revision 104959)
+++ chrome/browser/chromeos/login/new_user_view.h (working copy)
@@ -60,10 +60,7 @@
virtual void NavigateAway() = 0;
};
- // If |need_border| is true, RoundedRect border and background are required.
- NewUserView(Delegate* delegate,
- bool need_border,
- bool need_guest_link);
+ NewUserView(Delegate* delegate, bool need_guest_link);
virtual ~NewUserView();
@@ -129,7 +126,7 @@
private:
// Creates Link control and adds it as a child.
- void InitLink(views::Link** link);
+ views::Link* InitLink(SkColor background_color);
// Delete and recreate native controls that fail to update preferred size
// after text/locale update.
@@ -176,9 +173,6 @@
// True when login is in process.
bool login_in_process_;
- // If true, this view needs RoundedRect border and background.
- bool need_border_;
-
// Whether Guest Mode link is needed.
bool need_guest_link_;
« no previous file with comments | « chrome/browser/chromeos/login/network_selection_view.cc ('k') | chrome/browser/chromeos/login/new_user_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698