chrome/browser/ui/views/bubble/bubble.cc - Issue 8221027: Make views::Label and views::Link auto-color themselves to be readable over their background colo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bubble/bubble.cc

Issue 8221027: Make views::Label and views::Link auto-color themselves to be readable over their background colo... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/avatar_menu_bubble_view.cc ('K') | « chrome/browser/ui/views/bubble/bubble.h ('k') | chrome/browser/ui/views/default_search_view.h » ('j') | views/controls/label.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bubble/bubble.cc

===================================================================

--- chrome/browser/ui/views/bubble/bubble.cc (revision 104769)

+++ chrome/browser/ui/views/bubble/bubble.cc (working copy)

@@ -41,8 +41,8 @@

// BubbleDelegate ---------------------------------------------------------

-std::wstring BubbleDelegate::accessible_name() {

- return L"";

+string16 BubbleDelegate::GetAccessibleName() {

+ return string16();

}

// Bubble -----------------------------------------------------------------

@@ -228,7 +228,7 @@

border_->SetOpacity(0);

GetWidget()->SetOpacity(0);

}

- SetWindowText(GetNativeView(), delegate_->accessible_name().c_str());

+ SetWindowText(GetNativeView(), delegate_->GetAccessibleName().c_str());

#elif defined(TOOLKIT_USES_GTK)

views::Widget::InitParams params(type_);

params.transparent = true;