Make views::Label and views::Link auto-color themselves to be readable over their background colo...

chrome/browser/ui/views/sad_tab_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/sad_tab_view.h"
 
 #include "base/metrics/histogram.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/google/google_util.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 23 matching lines @@
 static const int kMessageFontSizeDelta = 0;
 #else
 static const int kTitleFontSizeDelta = 2;
 static const int kMessageFontSizeDelta = 1;
 #endif
 
 SadTabView::SadTabView(TabContents* tab_contents, Kind kind)
     : tab_contents_(tab_contents),
       kind_(kind),
       painted_(false),
+      base_font_(ResourceBundle::GetSharedInstance().GetFont(
+          ResourceBundle::BaseFont)),
       message_(NULL),
       help_link_(NULL),
       feedback_link_(NULL) {
   DCHECK(tab_contents);
 
   // Sometimes the user will never see this tab, so keep track of the total
   // number of creation events to compare to display events.
   UMA_HISTOGRAM_COUNTS("SadTab.Created", kind_);
 
   // Set the background color.
@@ skipping 34 matching lines @@
   SetLayoutManager(layout);
 
   const int column_set_id = 0;
   views::ColumnSet* columns = layout->AddColumnSet(column_set_id);
   columns->AddPaddingColumn(1, kPadding);
   columns->AddColumn(views::GridLayout::CENTER, views::GridLayout::CENTER,
                      0, views::GridLayout::USE_PREF, 0, 0);
   columns->AddPaddingColumn(1, kPadding);
 
   views::ImageView* image = new views::ImageView();
-  ResourceBundle& rb = ResourceBundle::GetSharedInstance();
-  image->SetImage(
-      rb.GetBitmapNamed((kind_ == CRASHED) ? IDR_SAD_TAB : IDR_KILLED_TAB));
+  image->SetImage(ResourceBundle::GetSharedInstance().GetBitmapNamed(
+      (kind_ == CRASHED) ? IDR_SAD_TAB : IDR_KILLED_TAB));
   layout->StartRowWithPadding(0, column_set_id, 1, kPadding);
   layout->AddView(image);
 
-  views::Label* title = new views::Label(l10n_util::GetStringUTF16(
+  views::Label* title = CreateLabel(l10n_util::GetStringUTF16(
       (kind_ == CRASHED) ? IDS_SAD_TAB_TITLE : IDS_KILLED_TAB_TITLE));
-  const gfx::Font& base_font = rb.GetFont(ResourceBundle::BaseFont);
-  title->SetFont(base_font.DeriveFont(kTitleFontSizeDelta, gfx::Font::BOLD));
-  title->SetColor(kTextColor);
+  title->SetFont(base_font_.DeriveFont(kTitleFontSizeDelta, gfx::Font::BOLD));
   layout->StartRowWithPadding(0, column_set_id, 0, kPadding);
   layout->AddView(title);
 
-  message_ = new views::Label(l10n_util::GetStringUTF16(
+  message_ = CreateLabel(l10n_util::GetStringUTF16(
       (kind_ == CRASHED) ? IDS_SAD_TAB_MESSAGE : IDS_KILLED_TAB_MESSAGE));
-  message_->SetFont(base_font.DeriveFont(kMessageFontSizeDelta));
-  message_->SetColor(kTextColor);
   message_->SetMultiLine(true);
   layout->StartRowWithPadding(0, column_set_id, 0, kPadding);
   layout->AddView(message_);
 
   if (tab_contents_) {
-    string16 help_link(l10n_util::GetStringUTF16(
+    help_link_ = CreateLink(l10n_util::GetStringUTF16(
         (kind_ == CRASHED) ? IDS_SAD_TAB_HELP_LINK : IDS_LEARN_MORE));
-    help_link_ = new views::Link(help_link);
-    help_link_->SetFont(base_font.DeriveFont(kMessageFontSizeDelta));
-    help_link_->SetNormalColor(kTextColor);
-    help_link_->set_listener(this);
 
     if (kind_ == CRASHED) {
       size_t offset = 0;
       string16 help_text(l10n_util::GetStringFUTF16(IDS_SAD_TAB_HELP_MESSAGE,
                                                     string16(), &offset));
-      views::Label* help_prefix =
-          new views::Label(help_text.substr(0, offset));
-      help_prefix->SetFont(base_font.DeriveFont(kMessageFontSizeDelta));
-      help_prefix->SetColor(kTextColor);
-      views::Label* help_suffix = new views::Label(help_text.substr(offset));
-      help_suffix->SetFont(base_font.DeriveFont(kMessageFontSizeDelta));
-      help_suffix->SetColor(kTextColor);
+      views::Label* help_prefix = CreateLabel(help_text.substr(0, offset));
+      views::Label* help_suffix = CreateLabel(help_text.substr(offset));
 
       const int help_column_set_id = 1;
       views::ColumnSet* help_columns = layout->AddColumnSet(help_column_set_id);
       help_columns->AddPaddingColumn(1, kPadding);
       // Center three middle columns for the help's [prefix][link][suffix].
       for (size_t column = 0; column < 3; column++)
         help_columns->AddColumn(views::GridLayout::CENTER,
             views::GridLayout::CENTER, 0, views::GridLayout::USE_PREF, 0, 0);
       help_columns->AddPaddingColumn(1, kPadding);
 
       layout->StartRowWithPadding(0, help_column_set_id, 0, kPadding);
       layout->AddView(help_prefix);
       layout->AddView(help_link_);
       layout->AddView(help_suffix);
     } else {
       layout->StartRowWithPadding(0, column_set_id, 0, kPadding);
       layout->AddView(help_link_);
 
-      feedback_link_ = new views::Link(
+      feedback_link_ = CreateLink(
           l10n_util::GetStringUTF16(IDS_KILLED_TAB_FEEDBACK_LINK));
-      feedback_link_->SetFont(base_font.DeriveFont(kMessageFontSizeDelta));
-      feedback_link_->SetNormalColor(kTextColor);
-      feedback_link_->set_listener(this);
       layout->StartRowWithPadding(0, column_set_id, 0, kPadding);
       layout->AddView(feedback_link_);
     }
   }
   layout->AddPaddingRow(1, kPadding);
 }
 
 void SadTabView::OnPaint(gfx::Canvas* canvas) {
   if (!painted_) {
     // User actually saw the error, keep track for user experience stats.
     UMA_HISTOGRAM_COUNTS("SadTab.Displayed", kind_);
     painted_ = true;
   }
   View::OnPaint(canvas);
 }
+
+views::Label* SadTabView::CreateLabel(const string16& text) {
+  views::Label* label = new views::Label(text);
+  label->SetFont(base_font_.DeriveFont(kMessageFontSizeDelta));
+  label->SetBackgroundColor(background()->get_color());
+  label->SetEnabledColor(kTextColor);
+  return label;
+}
+
+views::Link* SadTabView::CreateLink(const string16& text) {
+  views::Link* link = new views::Link(text);
+  link->SetFont(base_font_.DeriveFont(kMessageFontSizeDelta));
+  link->SetBackgroundColor(background()->get_color());
+  link->SetEnabledColor(kTextColor);
+  link->set_listener(this);
+  return link;
+}