Make views::Label and views::Link auto-color themselves to be readable over their background colo...

chrome/browser/chromeos/options/vpn_config_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/options/vpn_config_view.h"
 
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
@@ skipping 525 matching lines @@
   } else {
     group_name_label_ = NULL;
     group_name_textfield_ = NULL;
   }
 
   // Error label.
   layout->StartRow(0, column_view_set_id);
   layout->SkipColumns(1);
   error_label_ = new views::Label();
   error_label_->SetHorizontalAlignment(views::Label::ALIGN_LEFT);
-  error_label_->SetColor(SK_ColorRED);
+  error_label_->SetAutoColorReadabilityEnabled(false);

[sky, 2011/10/11 14:54:10]

I tend to think you don't need this for the subclasses of
ChildNetworkConfigView, but I'm not positive. If you ask the author I'm sure
they could tell you.

+  error_label_->SetEnabledColor(SK_ColorRED);
   layout->AddView(error_label_);
 
   // Set or hide the UI, update comboboxes and error labels.
   Refresh();
 }
 
 void VPNConfigView::Refresh() {
   NetworkLibrary* cros = CrosLibrary::Get()->GetNetworkLibrary();
 
   UpdateControls();
@@ skipping 150 matching lines @@
     return std::string();
   std::string untrimmed = UTF16ToUTF8(textfield->text());
   if (!trim_whitespace)
     return untrimmed;
   std::string result;
   TrimWhitespaceASCII(untrimmed, TRIM_ALL, &result);
   return result;
 }
 
 }  // namespace chromeos